Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751273AbdDJBA3 convert rfc822-to-8bit (ORCPT ); Sun, 9 Apr 2017 21:00:29 -0400 Received: from tyo161.gate.nec.co.jp ([114.179.232.161]:53113 "EHLO tyo161.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbdDJBA1 (ORCPT ); Sun, 9 Apr 2017 21:00:27 -0400 From: Naoya Horiguchi To: Anshuman Khandual CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" Subject: Re: [PATCH] mm/softoffline: Add page flag description in error paths Thread-Topic: [PATCH] mm/softoffline: Add page flag description in error paths Thread-Index: AQHSsNpv+hOvScJBzUSPQLgRYo1+FaG9JoEA Date: Mon, 10 Apr 2017 00:15:23 +0000 Message-ID: <20170410001522.GA31515@hori1.linux.bs1.fc.nec.co.jp> References: <20170409023829.10788-1-khandual@linux.vnet.ibm.com> In-Reply-To: <20170409023829.10788-1-khandual@linux.vnet.ibm.com> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.24] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <8C2EBC6C2C8DB344A9EAED6237A4F4C5@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2836 Lines: 73 On Sun, Apr 09, 2017 at 08:08:29AM +0530, Anshuman Khandual wrote: > It helps to provide page flag description along with the raw value in > error paths during soft offline process. From sample experiments > > Before the patch: > > [ 132.317977] soft offline: 0x6100: migration failed 1, type 3ffff800008018 > [ 132.359057] soft offline: 0x7400: migration failed 1, type 3ffff800008018 > > After the patch: > > [ 87.694325] soft offline: 0x5900: migration failed 1, type 3ffff800008018 (uptodate|dirty|head) > [ 87.736273] soft offline: 0x6c00: migration failed 1, type 3ffff800008018 (uptodate|dirty|head) > > Signed-off-by: Anshuman Khandual Looks good to me, thank you! Acked-by: Naoya Horiguchi > --- > mm/memory-failure.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 27f7210..fe64d77 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1543,8 +1543,8 @@ static int get_any_page(struct page *page, unsigned long pfn, int flags) > if (ret == 1 && !PageLRU(page)) { > /* Drop page reference which is from __get_any_page() */ > put_hwpoison_page(page); > - pr_info("soft_offline: %#lx: unknown non LRU page type %lx\n", > - pfn, page->flags); > + pr_info("soft_offline: %#lx: unknown non LRU page type %lx (%pGp)\n", > + pfn, page->flags, &page->flags); > return -EIO; > } > } > @@ -1585,8 +1585,8 @@ static int soft_offline_huge_page(struct page *page, int flags) > ret = migrate_pages(&pagelist, new_page, NULL, MPOL_MF_MOVE_ALL, > MIGRATE_SYNC, MR_MEMORY_FAILURE); > if (ret) { > - pr_info("soft offline: %#lx: migration failed %d, type %lx\n", > - pfn, ret, page->flags); > + pr_info("soft offline: %#lx: migration failed %d, type %lx (%pGp)\n", > + pfn, ret, page->flags, &page->flags); > /* > * We know that soft_offline_huge_page() tries to migrate > * only one hugepage pointed to by hpage, so we need not > @@ -1677,14 +1677,14 @@ static int __soft_offline_page(struct page *page, int flags) > if (!list_empty(&pagelist)) > putback_movable_pages(&pagelist); > > - pr_info("soft offline: %#lx: migration failed %d, type %lx\n", > - pfn, ret, page->flags); > + pr_info("soft offline: %#lx: migration failed %d, type %lx (%pGp)\n", > + pfn, ret, page->flags, &page->flags); > if (ret > 0) > ret = -EIO; > } > } else { > - pr_info("soft offline: %#lx: isolation failed: %d, page count %d, type %lx\n", > - pfn, ret, page_count(page), page->flags); > + pr_info("soft offline: %#lx: isolation failed: %d, page count %d, type %lx (%pGp)\n", > + pfn, ret, page_count(page), page->flags, &page->flags); > } > return ret; > } > -- > 1.8.5.2 > >