Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbdDJElf (ORCPT ); Mon, 10 Apr 2017 00:41:35 -0400 Received: from home.keithp.com ([63.227.221.253]:35936 "EHLO elaine.keithp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbdDJEle (ORCPT ); Mon, 10 Apr 2017 00:41:34 -0400 From: Keith Packard To: Daniel Vetter Cc: linux-kernel@vger.kernel.org, Dave Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths In-Reply-To: <20170402131926.gejo4wnicwwekgqk@phenom.ffwll.local> References: <20170401170841.2643-1-keithp@keithp.com> <20170401170841.2643-4-keithp@keithp.com> <20170402131926.gejo4wnicwwekgqk@phenom.ffwll.local> Date: Sun, 09 Apr 2017 19:06:36 -0600 Message-ID: <86bms5xe8z.fsf@hiro.keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 43 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > I think it'd be good if we could consolidate all the lease checking into > drm_mode_object_find (respectively __drm_mode_object_find). We'd need to > wire up the fpriv to be able to do that, but we could upstream that patch > right away before anything else. That should take care of most of the > checks in this patch here. Hrm. Without some major changes, the effect of this will be to have the lessee see only the objects which it holds a lease on. I think that's OK as the lessor will be doing object filtering for its clients, however it's not what Dave and I discussed, so I just want to make him aware that the kernel is going to be simpler than originally planned. We had originally discussed having the lessee see the un-leased objects, but to have them reported with different status. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAljq2p0ACgkQ2yIaaQAA ABH5MA//RFuxqbS8MCdybEYZ7I87/dtt3mKqh7d9l9yRs0NikPqjWobpc7fmg4Ur Wn/FWnHqpPxEE4SJOSlsjSqaxGUm56wxf4+62pki4jhQF2D9h4YPMhoPqFt6I3Ro 7sOR8iXPXeVGpBg7k+eojZzI2HZZfXxH/TwltlSt+OAJi3aXVjcmGvOk4YiFDQ1N iltePQLaoyW3t8gypOVCNy//le9V9UFQu23PMku8CWoO37+e/ileBVts4zRnZhSg asP3Q39foukRM5wbNmmDE73ID7zoJXOwhV/B4F0tsDyfusqILKiu1pY5vcy6eY8T XEkGGQSoRwKfdEDv0YHSpm/FZ+d/9D6ZDBijquKlQ8ftNOojmclXt393QW1rX01B Z+GQL4J6oh0OlTU+/KDHNotpO7438euk49vdAz41kcz6ElFeJW7g1LFp4sxM/1Je LYRgQMO+EcpBskrqK+GotTCBXcEB9hUYq7e0EnrzCGrFFtFw989wp7GLyjEYerb1 ic3wtqTji5/Y0LONIPVBI1C4YmZopm0uSNWtn5HvBJIUnfJ595KVeFAXSzar9CR1 NOVVp0kMl+zlr4kfuLDkB76xZYObZqE1sxXNOllqHYu1842e8X3Qm6dGpFa7wvmv 0/ZTN0b2rwSDpgEQ1rz2QUCuYrfF6kK53BQBQ20UjsHtXtvBxuQ= =lfm3 -----END PGP SIGNATURE----- --=-=-=--