Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000AbdDJHnU (ORCPT ); Mon, 10 Apr 2017 03:43:20 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:51059 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbdDJHnR (ORCPT ); Mon, 10 Apr 2017 03:43:17 -0400 Subject: Re: [PATCH net-next] bindings: net: stmmac: add missing note about LPI interrupt To: Sergei Shtylyov , Rob Herring , Mark Rutland , "David S. Miller" , Joao Pinto , Alexandre TORGUE , Giuseppe CAVALLARO , Thierry Reding , Eric Engestrom References: <20170407143100.21536-1-niklass@axis.com> CC: , , From: Niklas Cassel Message-ID: <379cb3b6-4b4f-b4f0-d5e2-1896c7b677b1@axis.com> Date: Mon, 10 Apr 2017 09:43:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX01.axis.com (10.0.5.15) To XBOX02.axis.com (10.0.5.16) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 42 On 04/07/2017 06:48 PM, Sergei Shtylyov wrote: > Hello! > > On 04/07/2017 05:30 PM, Niklas Cassel wrote: > >> From: Niklas Cassel >> >> The hardware has a LPI interrupt. >> There is already code in the stmmac driver to parse and handle the >> interrupt. However, this information was missing from the DT binding. >> >> Signed-off-by: Niklas Cassel >> --- >> Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt >> index f652b0c384ce..8977abc266ac 100644 >> --- a/Documentation/devicetree/bindings/net/stmmac.txt >> +++ b/Documentation/devicetree/bindings/net/stmmac.txt >> @@ -8,8 +8,8 @@ Required properties: >> that services interrupts for this device >> - interrupts: Should contain the STMMAC interrupts >> - interrupt-names: Should contain the interrupt names "macirq" >> - "eth_wake_irq" if this interrupt is supported in the "interrupts" >> - property >> + "eth_wake_irq" if this interrupt is supported in the "interrupts property > > Missed closing quote? Thanks for pointing it out. Will send a v2. > >> + "eth_lpi" if this interrupt is supported in the "interrupts" property >> - phy-mode: See ethernet.txt file in the same directory. >> - snps,reset-gpio gpio number for phy reset. >> - snps,reset-active-low boolean flag to indicate if phy reset is active low. > [...] > > MBR, Sergei >