Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbdDJJDF (ORCPT ); Mon, 10 Apr 2017 05:03:05 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:51697 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbdDJJDE (ORCPT ); Mon, 10 Apr 2017 05:03:04 -0400 Message-ID: <1491814982.3087.27.camel@pengutronix.de> Subject: Re: [PATCH] reset: hi6220: Set module license so that it can be loaded From: Philipp Zabel To: Jeremy Linton Cc: linux-kernel@vger.kernel.org, saberlily.xia@hisilicon.com, puck.chen@hisilicon.com, xinliang.liu@linaro.org Date: Mon, 10 Apr 2017 11:03:02 +0200 In-Reply-To: <20170408071840.29380-1-lintonrjeremy@gmail.com> References: <20170408071840.29380-1-lintonrjeremy@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 27 On Sat, 2017-04-08 at 02:18 -0500, Jeremy Linton wrote: > The hi6220_reset driver can be built as a standalone module > yet it cannot be loaded because it depends on GPL exported symbols. > > Lets set the module license so that the module loads, and things like > the on-board kirin drm starts working. > > Signed-off-by: Jeremy Linton > --- > drivers/reset/hisilicon/hi6220_reset.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c > index 35ce53e..d5e5229 100644 > --- a/drivers/reset/hisilicon/hi6220_reset.c > +++ b/drivers/reset/hisilicon/hi6220_reset.c > @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void) > } > > postcore_initcall(hi6220_reset_init); > + > +MODULE_LICENSE("GPL v2"); Applied, thanks. regards Philipp