Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753385AbdDJLWG (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Apr 2017 07:22:06 -0400
Received: from esa1.microchip.iphmx.com ([68.232.147.91]:48548 "EHLO
        esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753330AbdDJLVz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Apr 2017 07:21:55 -0400
X-IronPort-AV: E=Sophos;i="5.37,182,1488870000"; 
   d="scan'208";a="1351575"
Subject: Re: [PATCH v3] Staging: most: use __func__ instead of the function
 name
To: chandrasekhar annamaneni <chandra627@gmail.com>,
        <andrey.shvetsov@k2l.de>
References: <alpine.DEB.2.20.1703171242310.3207@turtle>
 <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
CC: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
From: Christian Gromm <christian.gromm@microchip.com>
Message-ID: <facc128f-d789-3e72-db70-e78526266a4f@microchip.com>
Date: Mon, 10 Apr 2017 13:21:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3080
Lines: 90


Sorry for the delay...


On 04/10/2017 05:24 AM, chandrasekhar annamaneni wrote:
>
> Second reminder, please review.
>
> Thanks.
> Chandra
>
>
> On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni
> <chandra627@gmail.com <mailto:chandra627@gmail.com>> wrote:
>
>
>     Change video.c to use %s, __func__ instead of function names.
>     Warnings flagged by checkpatch.pl <http://checkpatch.pl>
>
>     Signed-off-by: Chandra Annamaneni <chandra627@gmail.com
>     <mailto:chandra627@gmail.com>>

Acked-by: Christian Gromm <christian.gromm@microchip.com>

>
>     diff --git a/drivers/staging/most/aim-v4l2/video.c
>     b/drivers/staging/most/aim-v4l2/video.c
>     index e074841..59e861e 100644
>     --- a/drivers/staging/most/aim-v4l2/video.c
>     +++ b/drivers/staging/most/aim-v4l2/video.c
>     @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
>             struct most_video_dev *mdev = video_drvdata(filp);
>             struct aim_fh *fh;
>
>     -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
>     +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>             switch (vdev->vfl_type) {
>             case VFL_TYPE_GRABBER:
>     @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
>             struct most_video_dev *mdev = fh->mdev;
>             struct mbo *mbo, *tmp;
>
>     -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
>     +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>             /*
>              * We need to put MBOs back before we call most_stop_channel()
>     @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void
>     *priv, v4l2_std_id *norm)
>             struct aim_fh *fh = priv;
>             struct most_video_dev *mdev = fh->mdev;
>
>     -       v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
>     +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>             *norm = V4L2_STD_UNKNOWN;
>             return 0;
>     @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file,
>     void *priv, unsigned int index)
>             struct aim_fh *fh = priv;
>             struct most_video_dev *mdev = fh->mdev;
>
>     -       v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index);
>     +       v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
>
>             if (index >= V4L2_AIM_MAX_INPUT)
>                     return -EINVAL;
>     @@ -441,7 +441,7 @@ static int aim_register_videodev(struct
>     most_video_dev *mdev)
>      {
>             int ret;
>
>     -       v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
>     +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>             init_waitqueue_head(&mdev->wait_data);
>
>     @@ -471,7 +471,7 @@ static int aim_register_videodev(struct
>     most_video_dev *mdev)
>
>      static void aim_unregister_videodev(struct most_video_dev *mdev)
>      {
>     -       v4l2_info(&mdev->v4l2_dev, "aim_unregister_videodev()\n");
>     +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>             video_unregister_device(mdev->vdev);
>      }
>
>