Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313AbdDJLsS (ORCPT ); Mon, 10 Apr 2017 07:48:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57752 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbdDJLsQ (ORCPT ); Mon, 10 Apr 2017 07:48:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A435160862 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org From: Sricharan R Subject: Re: [PATCH] of: change fixup of dma-ranges size to error To: Frank Rowand , Rob Herring , Robin Murphy References: <1491459529-31391-1-git-send-email-frowand.list@gmail.com> <58E68ADC.6040603@gmail.com> <58E72123.4040607@gmail.com> <58E82008.7000102@gmail.com> Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-ID: <19a2a28f-8338-970e-3b5f-05be3362fb9a@codeaurora.org> Date: Mon, 10 Apr 2017 17:18:11 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <58E82008.7000102@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1984 Lines: 51 Hi Frank, >>> Can we get back to the basic premise of the proposed patch? >>> >>> The current code in of_dma_configure() contains a hack that allows the >>> dma-ranges property to specify a mask instead of a size. The binding >>> in the specification allows a size and does not allow a mask. >>> >>> The hack was added to account for one or more dts files that did not >>> follow the specification. In the mail list discussion of the hack >>> you said "Also, we need a WARN here so DTs get fixed." >>> >>> The hack was first present in Linux 4.1. The only in-tree dts that >>> incorrectly contained a mask instead of a size in dma-ranges was >>> arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi >>> >>> That .dtsi was fixed by >>> commit c91cb9123cdd ("dtb: amd: Fix DMA ranges in device tree") >>> The fix was present in Linux 4.6, May 15, 2016. >>> >>> I would like to remove the hack. I think that enough time has >>> elapsed to allow this change. >> >> If we have no cases of what I'm concerned about, then removing it is >> fine. Is this a dependency for iommu series? Doesn't look like it to >> me. > > This patch is a replacement for patch 03/12 in the iommu series. I > think that patch 03/12 of the iommu series could be dropped and my > patch could be applied independently of the iommu series. > > There is likely a conflict between my patch and patch 06/12 of the > iommu series because in my patch the first line of the patch chunk > of drivers/of/device.c includes a line that is changed in 06/12 > of the iommu series. If this is the case then the iommu series > should take precedence over my patch (and I should subsequently > fixup my patch). > Ok, for which i just posted a V11 [1] with patch 03/12 from V10 dropped. [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1373638.html Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation