Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbdDJNUc (ORCPT ); Mon, 10 Apr 2017 09:20:32 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:50318 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753379AbdDJNUA (ORCPT ); Mon, 10 Apr 2017 09:20:00 -0400 Message-ID: <1491830352.31980.52.camel@coelho.fi> From: Luca Coelho To: "Luis R. Rodriguez" , gregkh@linuxfoundation.org Cc: wagi@monom.org, dwmw2@infradead.org, rafal@milecki.pl, arend.vanspriel@broadcom.com, rjw@rjwysocki.net, yi1.li@linux.intel.com, atull@opensource.altera.com, moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, kvalo@codeaurora.org, luto@kernel.org, takahiro.akashi@linaro.org, dhowells@redhat.com, pjones@redhat.com, linux-kernel@vger.kernel.org Date: Mon, 10 Apr 2017 16:19:12 +0300 In-Reply-To: <20170330032514.17173-5-mcgrof@kernel.org> References: <20170330032514.17173-1-mcgrof@kernel.org> <20170330032514.17173-5-mcgrof@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 91.156.4.241 X-SA-Exim-Mail-From: luca@coelho.fi Subject: Re: [PATCH v6 4/5] iwlwifi: convert to use driver data API X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on farmhouse.coelho.fi) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 39 On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > The driver data API provides support for looking for firmware > from a specific set of API ranges, so just use that. Since we > free the firmware on the callback immediately after consuming it, > this also takes avantage of that feature. > > Signed-off-by: Luis R. Rodriguez > --- Looks find, with one nitpick. > drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 67 ++++++++++------------------ > 1 file changed, 23 insertions(+), 44 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c > index be466a074c1d..b6643aa5b344 100644 > --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c [...] > @@ -1541,11 +1522,9 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans) > } > #endif > > - ret = iwl_request_firmware(drv, true); > - if (ret) { > - IWL_ERR(trans, "Couldn't request the fw\n"); > + ret = iwl_request_firmware(drv); > + if (ret) > goto err_fw; > - } Why remove the error message here? -- Cheers, Luca.