Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbdDJNnn (ORCPT ); Mon, 10 Apr 2017 09:43:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42992 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbdDJNnl (ORCPT ); Mon, 10 Apr 2017 09:43:41 -0400 Date: Mon, 10 Apr 2017 15:43:32 +0200 From: Greg Kroah-Hartman To: Varsha Rao Cc: Arnd Bergmann , Matthew Wilcox , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drivers: char: Replace fail_printk with fail_print. Message-ID: <20170410134332.GB21327@kroah.com> References: <58eb2d71.4228ed0a.41ebe.ea26@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58eb2d71.4228ed0a.41ebe.ea26@mx.google.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 32 On Mon, Apr 10, 2017 at 12:29:56PM +0530, Varsha Rao wrote: > As printk is no longer used here, rename the label fail_printk as > fail_print. > > Signed-off-by: Varsha Rao > --- > drivers/char/misc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/misc.c b/drivers/char/misc.c > index 5786281..0fed477 100644 > --- a/drivers/char/misc.c > +++ b/drivers/char/misc.c > @@ -293,11 +293,11 @@ static int __init misc_init(void) > > err = -EIO; > if (register_chrdev(MISC_MAJOR, "misc", &misc_fops)) > - goto fail_printk; > + goto fail_print; > misc_class->devnode = misc_devnode; > return 0; > > -fail_printk: > +fail_print: > pr_err("unable to get major %d for misc devices\n", MISC_MAJOR); > class_destroy(misc_class); That's really a pointless change, don't you think? sorry, greg k-h