Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbdDJNwl (ORCPT ); Mon, 10 Apr 2017 09:52:41 -0400 Received: from mail-ua0-f176.google.com ([209.85.217.176]:34842 "EHLO mail-ua0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbdDJNwh (ORCPT ); Mon, 10 Apr 2017 09:52:37 -0400 MIME-Version: 1.0 In-Reply-To: <1491004256-13969-2-git-send-email-sergio.prado@e-labworks.com> References: <1491004256-13969-1-git-send-email-sergio.prado@e-labworks.com> <1491004256-13969-2-git-send-email-sergio.prado@e-labworks.com> From: Ulf Hansson Date: Mon, 10 Apr 2017 15:52:35 +0200 Message-ID: Subject: Re: [PATCH v6 1/2] dt-bindings: mmc: add DT binding for S3C24XX MMC/SD/SDIO controller To: Sergio Prado Cc: Rob Herring , Mark Rutland , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ben Dooks , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2661 Lines: 69 On 1 April 2017 at 01:50, Sergio Prado wrote: > Adds the device tree bindings description for Samsung S3C24XX > MMC/SD/SDIO controller, used as a connectivity interface with external > MMC, SD and SDIO storage mediums. > > Acked-by: Rob Herring > Signed-off-by: Sergio Prado Thanks, applied for next! Kind regards Uffe > --- > .../devicetree/bindings/mmc/samsung,s3cmci.txt | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt > > diff --git a/Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt b/Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt > new file mode 100644 > index 000000000000..5f68feb9f9d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt > @@ -0,0 +1,42 @@ > +* Samsung's S3C24XX MMC/SD/SDIO controller device tree bindings > + > +Samsung's S3C24XX MMC/SD/SDIO controller is used as a connectivity interface > +with external MMC, SD and SDIO storage mediums. > + > +This file documents differences between the core mmc properties described by > +mmc.txt and the properties used by the Samsung S3C24XX MMC/SD/SDIO controller > +implementation. > + > +Required SoC Specific Properties: > +- compatible: should be one of the following > + - "samsung,s3c2410-sdi": for controllers compatible with s3c2410 > + - "samsung,s3c2412-sdi": for controllers compatible with s3c2412 > + - "samsung,s3c2440-sdi": for controllers compatible with s3c2440 > +- reg: register location and length > +- interrupts: mmc controller interrupt > +- clocks: Should reference the controller clock > +- clock-names: Should contain "sdi" > + > +Required Board Specific Properties: > +- pinctrl-0: Should specify pin control groups used for this controller. > +- pinctrl-names: Should contain only one value - "default". > + > +Optional Properties: > +- bus-width: number of data lines (see mmc.txt) > +- cd-gpios: gpio for card detection (see mmc.txt) > +- wp-gpios: gpio for write protection (see mmc.txt) > + > +Example: > + > + mmc0: mmc@5a000000 { > + compatible = "samsung,s3c2440-sdi"; > + pinctrl-names = "default"; > + pinctrl-0 = <&sdi_pins>; > + reg = <0x5a000000 0x100000>; > + interrupts = <0 0 21 3>; > + clocks = <&clocks PCLK_SDI>; > + clock-names = "sdi"; > + bus-width = <4>; > + cd-gpios = <&gpg 8 GPIO_ACTIVE_LOW>; > + wp-gpios = <&gph 8 GPIO_ACTIVE_LOW>; > + }; > -- > 1.9.1 >