Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692AbdDJO4d (ORCPT ); Mon, 10 Apr 2017 10:56:33 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:32946 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753340AbdDJOzd (ORCPT ); Mon, 10 Apr 2017 10:55:33 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170407181754.GL30290@intel.com> <1491590329.10124.86.camel@edumazet-glaptop3.roam.corp.google.com> <20170407.114216.29873489271414092.davem@davemloft.net> <20170408102305.GA4522@electric-eye.fr.zoreil.com> From: Eric Dumazet Date: Mon, 10 Apr 2017 07:55:31 -0700 Message-ID: Subject: Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()") To: whiteheadm@acm.org Cc: Francois Romieu , ville.syrjala@linux.intel.com, David Miller , Eric Dumazet , netdev , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 31 On Mon, Apr 10, 2017 at 7:22 AM, tedheadster wrote: > On Sat, Apr 8, 2017 at 6:23 AM, Francois Romieu wrote: >> David Miller : >> [...] >>> One theory is that the interrupt masking isn't working properly >>> and interrupts are still arriving and hitting the NAPI state even >>> when we are actively polling NAPI. >>> >>> And this problem was masked by the locking done here. >> >> Yes. >> >> Ville, can you rule out irq sharing between the 8139 and some other >> device ? It's a candidate for unexpected interrupt handler invocation >> with older pc, even with properly working hardware. >> > > Eric, > If napi_complete_done() calls could affect drivers on older > hardware, I can test the following: > > drivers/net/ethernet/3com/typhoon.c > drivers/net/ethernet/amd/pcnet32.c > drivers/net/ethernet/broadcom/tg3.c > drivers/net/ethernet/dec/tulip/interrupt.c > drivers/net/ethernet/intel/e100.c > drivers/net/ethernet/intel/e1000/e1000_main.c > drivers/net/ethernet/smsc/epic100.c > drivers/net/ethernet/via/via-rhine.c That would be great, thanks Matthew.