Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753072AbdDJQXF (ORCPT ); Mon, 10 Apr 2017 12:23:05 -0400 Received: from foss.arm.com ([217.140.101.70]:50564 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbdDJQXE (ORCPT ); Mon, 10 Apr 2017 12:23:04 -0400 Date: Mon, 10 Apr 2017 17:23:06 +0100 From: Juri Lelli To: Catalin Marinas Cc: linux-kernel@vger.kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, broonie@kernel.org, will.deacon@arm.com, gregkh@linuxfoundation.org, dietmar.eggemann@arm.com, Russell King , robh+dt@kernel.org, sudeep.holla@arm.com, linux@arm.linux.org.uk, morten.rasmussen@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 5/9] arm, arm64: factorize common cpu capacity default code Message-ID: <20170410162306.GH30804@e106622-lin> References: <20170327131825.32134-1-juri.lelli@arm.com> <20170327131825.32134-6-juri.lelli@arm.com> <20170410081806.GB27538@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170410081806.GB27538@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 47 Hi, On 10/04/17 09:18, Catalin Marinas wrote: > On Mon, Mar 27, 2017 at 02:18:21PM +0100, Juri Lelli wrote: > > arm and arm64 share lot of code relative to parsing CPU capacity > > information from DT, using that information for appropriate scaling and > > exposing a sysfs interface for chaging such values at runtime. > > > > Factorize such code in a common place (driver/base/arch_topology.c) in > > preparation for further additions. > > > > Suggested-by: Will Deacon > > Suggested-by: Mark Rutland > > Suggested-by: Catalin Marinas > > Cc: Russell King > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Greg Kroah-Hartman > > Signed-off-by: Juri Lelli > > --- > > > > Changes from v2: > > - make capacity_scale and raw_capacity static > > - added SPDX header > > - improved indent > > - misc. whitespaces/newlines fixes > > > > Changes from v1: > > - keep the original GPLv2 header > > --- > > arch/arm/Kconfig | 1 + > > arch/arm/kernel/topology.c | 213 ++----------------------------------- > > arch/arm64/Kconfig | 1 + > > arch/arm64/kernel/topology.c | 219 +-------------------------------------- > > drivers/base/Kconfig | 8 ++ > > drivers/base/Makefile | 1 + > > drivers/base/arch_topology.c | 242 +++++++++++++++++++++++++++++++++++++++++++ > > For arm64: > > Acked-by: Catalin Marinas Thanks for reviewing the series. Best, - Juri