Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752642AbdDJQZr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Apr 2017 12:25:47 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:51864 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752002AbdDJQZq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Apr 2017 12:25:46 -0400
Date: Mon, 10 Apr 2017 18:25:44 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@amacapital.net>
cc: LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Mathias Krause <minipli@googlemail.com>
Subject: Re: [patch 3/3] x86/vdso: Sanitize vdso*_enabled handling
In-Reply-To: <CALCETrU2JOa0Roz_-Vtpq_NZJNFPf-fY=JxeZ+nsA0BMRqtHCg@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1704101808120.2906@nanos>
References: <20170410151426.808543816@linutronix.de> <20170410151723.692402894@linutronix.de> <CALCETrU2JOa0Roz_-Vtpq_NZJNFPf-fY=JxeZ+nsA0BMRqtHCg@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 644
Lines: 19

On Mon, 10 Apr 2017, Andy Lutomirski wrote:

> On Mon, Apr 10, 2017 at 8:14 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > +static int vdso32_sysctl;
> > +
> > +static int vdso_update_handler(struct ctl_table *table, int write,
> > +                              void __user *buffer, size_t *lenp,
> > +                              loff_t *ppos)
> > +{
> > +       int ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
> 
> Using a global for the temporary is gross and mildly racy.  I would
> just open-code the conversion.  Or, even better, add proc_dobool().

Dammit, thought about it and then got lazy. :(

Thanks,

	tglx