Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbdDJSKx convert rfc822-to-8bit (ORCPT ); Mon, 10 Apr 2017 14:10:53 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:53326 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbdDJSKv (ORCPT ); Mon, 10 Apr 2017 14:10:51 -0400 Date: Mon, 10 Apr 2017 19:10:41 +0100 User-Agent: K-9 Mail for Android In-Reply-To: References: <20170328215259.31622-1-raltherr@google.com> <20170328215259.31622-2-raltherr@google.com> <20170405215046.GE7065@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH v5 2/2] iio: Aspeed ADC To: Rick Altherr , Jonathan Cameron CC: Stephen Boyd , OpenBMC Maillist , Linux Kernel Mailing List , William Breathitt Gray , Michael Turquette , Andreas Klinger , Rob Herring , Peter Meerwald-Stadler , Quentin Schulz , linux-iio@vger.kernel.org, Zhiyong Tao , Geert Uytterhoeven , Lars-Peter Clausen , Raveendra Padasalagi , Scott Branden , Crestez Dan Leonard , Akinobu Mita , Fabrice Gasnier , Hartmut Knaack , linux-clk@vger.kernel.org From: Jonathan Cameron Message-ID: <010B362C-9A21-4C6B-B810-59C02BB8097C@jic23.retrosnub.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2104 Lines: 60 On 10 April 2017 17:34:33 BST, Rick Altherr wrote: >I don't believe there are any bindings changes or a need to revert. >Stephen's suggested changes are small improvements that make the driver >suitable for non-DT platforms (not an issue anytime soon) and help with >a >planned refactor of the clk_hw structure. I'll send out follow-up >changes >when Stephen and I have reached consensus on how to resolve the latter >improvement. Cool. Thanks Jonathan > >On Sat, Apr 8, 2017 at 9:15 AM, Jonathan Cameron >wrote: > >> On 05/04/17 22:50, Stephen Boyd wrote: >> > On 04/01, Jonathan Cameron wrote: >> >> On 28/03/17 22:52, Rick Altherr wrote: >> >>> Aspeed BMC SoCs include a 16 channel, 10-bit ADC. Low and high >> threshold >> >>> interrupts are supported by the hardware but are not currently >> implemented. >> >>> >> >>> Signed-off-by: Rick Altherr >> >> Two really trivial things inline. I'll fix them whilst applying >rather >> than >> >> having you do a v6 - please do sanity check I haven't messed it up >> though! >> >> >> >> Applied to the togreg branch of iio.git and pushed out as testing >for >> >> the autobuilders to play with it. >> >> >> > >> > Oh I was too late. Blame work. Anyway, I made some comments on >> > v4. If they're fixed in a later patch or discussed on list that's >> > fine. No worries on my end. >> > >> Oops. I went a bit quick on this one I guess. >> >> Anyhow, from a quick read of your comments I'm not sure if any of >> them are such that we should revert. Perhaps we Rick can prepare >> a follow up patch covering them? I got a little lost so am not >> sure but if there is anything effecting bindings Rick, please >> get this through asap or let me know if we need to revert for now. >> Even if it is a case of adding a bit of binding and following up >> with the code using it a bit later. >> >> I'd asked for input on the clock stuff then forgot all about it on >> the later version. Sorry about that! >> >> Jonathan >> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.