Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753040AbdDJVXG (ORCPT ); Mon, 10 Apr 2017 17:23:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53300 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbdDJVXE (ORCPT ); Mon, 10 Apr 2017 17:23:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7D97037EE7 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7D97037EE7 Date: Tue, 11 Apr 2017 00:23:01 +0300 From: "Michael S. Tsirkin" To: Mike Galbraith Cc: Christoph Hellwig , Thorsten Leemhuis , virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Message-ID: <20170411002012-mutt-send-email-mst@kernel.org> References: <1491544999.5501.7.camel@gmx.de> <20170407090354-mutt-send-email-mst@kernel.org> <1491547457.5501.10.camel@gmx.de> <1491548751.5501.12.camel@gmx.de> <1491549722.5501.13.camel@gmx.de> <20170407161641-mutt-send-email-mst@kernel.org> <20170407163437-mutt-send-email-mst@kernel.org> <1491575393.3341.0.camel@gmx.de> <20170407215510-mutt-send-email-mst@kernel.org> <1491627694.4479.21.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491627694.4479.21.camel@gmx.de> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 10 Apr 2017 21:23:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 43 On Sat, Apr 08, 2017 at 07:01:34AM +0200, Mike Galbraith wrote: > On Fri, 2017-04-07 at 21:56 +0300, Michael S. Tsirkin wrote: > > > OK. test3 and test4 are now pushed: test3 should fix your hang, > > test4 is trying to fix a crash reported independently. > > test3 does not fix the post hibernate hang business that I can easily > reproduce, those are NFS, and at least as old as 4.4. Host/guest, > dunno, put 4.4 on both, guest hangs intermittently. OK so IIUC you agree it's a good idea to send test4 to Linus, right? Hybernation's still broken but that's not a regression. > [] __rpc_wait_for_completion_task+0x30/0x30 [sunrpc] > [] rpc_wait_bit_killable+0x1e/0xb0 [sunrpc] > [] __rpc_wait_for_completion_task+0x30/0x30 [sunrpc] > [] autoremove_wake_function+0x50/0x50 > [] call_decode+0x850/0x850 [sunrpc] > [] call_decode+0x850/0x850 [sunrpc] > [] __rpc_execute+0x14e/0x440 [sunrpc] > [] ktime_get+0x35/0xa0 > [] rpc_run_task+0x120/0x170 [sunrpc] > [] nfs4_call_sync_sequence+0x56/0x80 [nfsv4] > [] _nfs4_proc_getattr+0xb0/0xc0 [nfsv4] > [] path_lookupat+0xd2/0x100 > [] nfs4_proc_getattr+0x5c/0xe0 [nfsv4] > [] __nfs_revalidate_inode+0xa0/0x300 [nfs] > [] nfs_getattr+0x95/0x250 [nfs] > [] vfs_statx+0x7b/0xc0 > [] SYSC_newstat+0x20/0x40 > [] entry_SYSCALL_64_fastpath+0x1a/0xa9 > [] 0xffffffffffffffff > > I noted no _other_ misbehavior in either kernel, w/wo threadirqs. > > -Mike Interesting. I would guess virtio net does not complete some packets. So you were unable to find an old guest where this works fine? -- MST