Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbdDJXro (ORCPT ); Mon, 10 Apr 2017 19:47:44 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:59373 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbdDJXrm (ORCPT ); Mon, 10 Apr 2017 19:47:42 -0400 X-IronPort-AV: E=Sophos;i="5.37,184,1488816000"; d="scan'208";a="9590938" From: Bart Van Assche To: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "kys@microsoft.com" , "longli@microsoft.com" , "axboe@kernel.dk" CC: "sthemmin@microsoft.com" Subject: Re: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart Thread-Topic: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart Thread-Index: AQHSrmzSSZ/m2CRLtUe7E7wgCa1JMaG3faCAgAA0AwCAAAICgIAACeaAgAePRgA= Date: Mon, 10 Apr 2017 23:47:39 +0000 Message-ID: <1491868058.4199.28.camel@sandisk.com> References: <1491437781-3565-1-git-send-email-longli@exchange.microsoft.com> <1491438735.2787.18.camel@sandisk.com> <1491450335.8994.1.camel@sandisk.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=sandisk.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [63.163.107.100] x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1535;7:E92UKKN/v9ZkFJWbEEoToCvDIbl8RrL6qh1FbWN5/88UQPb87TJMdG4vNn5s18aWR1jH8V41DCsZJYlhQx4V3CL0DC/eEOGlWGoKr0virr+OcDfy5YPl+FB4nIzR4Qv3fNg8NnzZFuf+HA+nUqYLe0ki7TNSAJoaCpdGAnOf65voCQYulmWtDGs7gH2CsrXy4CaC3ev+P5WpnAFkGuiAt42dqIHemPgZi8/calacNRIPOrzF/oK5eq+lzJCPJAG4Soj+/hsm89WrpZKrn5W/9Ma6vGIIw3ALpjdtmM0yHSxlMZjcuLIwmqDVSy1NrFxybf3gpSLrjE8isa9ZALWE9w==;20:99/pmK7n0/7ltef3lcxzJTz3hiTO352tww8XdFuM/gZ+1ADNQ9E08Z/WSCGGDXKRbo/EtZBfO5Xd6YQBkjflm5ftbmDbEqxZZivkAwaji7kgoKUVedJ5+H4dVLn/r3FvXswackQs1uKUGalzHiaqCmDZ4w4fX+RJyWU9Aa2obKU= x-ms-office365-filtering-correlation-id: d16993bf-a879-48f1-a824-08d4806bf932 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:CY1PR0401MB1535; wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(67672495146484)(42932892334569); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:CY1PR0401MB1535;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1535; x-forefront-prvs: 027367F73D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39860400002)(39850400002)(39400400002)(39410400002)(39840400002)(377454003)(13464003)(377424004)(24454002)(2950100002)(25786009)(53546009)(5660300001)(189998001)(2421001)(66066001)(3660700001)(33646002)(38730400002)(103116003)(3280700002)(229853002)(1511001)(2906002)(4326008)(122556002)(2900100001)(102836003)(81166006)(2201001)(99286003)(8666007)(575784001)(86362001)(345774005)(6436002)(305945005)(8936002)(2561002)(53936002)(6512007)(6506006)(8676002)(77096006)(3846002)(6486002)(6116002)(7736002)(76176999)(93886004)(54356999)(36756003)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1535;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2017 23:47:39.4463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3ANlmVd027813 Content-Length: 2622 Lines: 76 On Thu, 2017-04-06 at 04:21 +0000, KY Srinivasan wrote: > > -----Original Message----- > > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com] > > Sent: Wednesday, April 5, 2017 8:46 PM > > To: linux-kernel@vger.kernel.org; linux-block@vger.kernel.org; Long Li > > ; axboe@kernel.dk > > Cc: Stephen Hemminger ; KY Srinivasan > > > > Subject: Re: [PATCH] block-mq: set both block queue and hardware queue > > restart bit for restart > > > > On Thu, 2017-04-06 at 03:38 +0000, Long Li wrote: > > > > -----Original Message----- > > > > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com] > > > > > > > > Please drop this patch. I'm working on a better solution. > > > > > > Thank you. Looking forward to your patch. > > > > Hello Long, > > > > It would help if you could share the name of the block or SCSI driver with > > which you ran into that lockup and also if you could share the name of the > > I/O scheduler used in your test. > > The tests that indicated the issue were run Hyper-V. The driver is storvsc_drv.c > The I/O scheduler was I think noop. Hello Long and K.Y., Thank you for the feedback. Can you repeat your test with kernel v4.11-rc6? The patches that went into the block layer for v4.11-rc6 should be sufficient to fix this: $ PAGER= git log --format=short v4.11-rc5..v4.11-rc6 block include/linux/blk* ? commit 6d8c6c0f97ad8a3517c42b179c1dc8e77397d0e2 Author: Bart Van Assche ????blk-mq: Restart a single queue if tag sets are shared commit 7587a5ae7eef0439f7be31f1b5959af062bbc5ec Author: Bart Van Assche ????blk-mq: Introduce blk_mq_delay_run_hw_queue() commit ebe8bddb6e30d7a02775b9972099271fc5910f37 Author: Omar Sandoval ????blk-mq: remap queues when adding/removing hardware queues commit 54d5329d425650fafaf90660a139c771d2d49cae Author: Omar Sandoval ????blk-mq-sched: fix crash in switch error path commit 93252632e828da3e90241a1c0e766556abf71598 Author: Omar Sandoval ????blk-mq-sched: set up scheduler tags when bringing up new queues commit 6917ff0b5bd4139e08a3f3146529dcb3b95ba7a6 Author: Omar Sandoval ????blk-mq-sched: refactor scheduler initialization commit 81380ca10778b99dce98940cfc993214712df335 Author: Omar Sandoval ????blk-mq: use the right hctx when getting a driver tag fails commit ac77a0c463c1d7d659861f7b6d1261970dd3282a Author: Minchan Kim ????block: do not put mq context in blk_mq_alloc_request_hctx Bart.