Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbdDKABi (ORCPT ); Mon, 10 Apr 2017 20:01:38 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:35994 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbdDKABg (ORCPT ); Mon, 10 Apr 2017 20:01:36 -0400 Date: Tue, 11 Apr 2017 09:01:23 +0900 From: Tejun Heo To: Zefan Li Cc: dvyukov@google.com, LKML , Cgroups Subject: Re: [PATCH] cgroup: avoid attaching a cgroup root to two different superblocks Message-ID: <20170411000123.GC28603@wtj.duckdns.org> References: <58E7532B.4030505@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58E7532B.4030505@huawei.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 500 Lines: 17 On Fri, Apr 07, 2017 at 04:51:55PM +0800, Zefan Li wrote: > We end up using the same cgroup root for two different superblocks, > so percpu_ref_kill() will be called twice on the same root when the > two superblocks are destroyed. > > We should fix to make sure the superblock pinning is really successful. > > Cc: stable@vger.kernel.org # 3.16+ > Reported-by: Dmitry Vyukov > Signed-off-by: Zefan Li Applied to cgroup/for-4.11-fixes. Thanks. -- tejun