Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbdDKBm2 (ORCPT ); Mon, 10 Apr 2017 21:42:28 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35851 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbdDKBm1 (ORCPT ); Mon, 10 Apr 2017 21:42:27 -0400 Date: Tue, 11 Apr 2017 09:42:23 +0800 From: Wei Yang To: David Rientjes Cc: Wei Yang , kirill@shutemov.name, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed Message-ID: <20170411014223.GA35630@WeideMacBook-Pro.local> Reply-To: Wei Yang References: <20170410165652.50250-1-richard.weiyang@gmail.com> <20170410165652.50250-3-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2114 Lines: 69 --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 10, 2017 at 05:26:03PM -0700, David Rientjes wrote: >On Tue, 11 Apr 2017, Wei Yang wrote: > >> According to current code path, numa_nodes_parsed is already setup when >> numa_emucation() is called. >>=20 >> x86_numa_init() >> numa_init() >> init_func() >>=20 >> numa_emulation() >>=20 >> numa_register_memblks() >> > >s/numa_emucation/numa_emulation/, but I think everything above should just= =20 >be reworded to say the following since it establishes the dependency: > >numa_init() has already called init_func(), which is responsible for=20 >setting numa_nodes_parsed, so use this nodemask instead of re-finding it= =20 >when calling numa_emulation(). > Yep, thanks. Looks your change log is better :-) >> This means we can get the physnode_mask directly from numa_nodes_parsed.= At >> the same time, this patch correct the comment of these two functions. >>=20 >> Signed-off-by: Wei Yang > >Acked-by: David Rientjes --=20 Wei Yang Help you, Help me --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJY7DR/AAoJEKcLNpZP5cTdFf0P/3qhAgFtGnxKM9VOOpoHjRMt JR1w52bWLKFHtlOn8K12G8iib0C9CIJYKAiiGsikN7UKRWr9KGZoBLU1Ex0mW8Hm VIF0OPpKDibSYa52PTxMOWR6NfudWYVjeswUPMSzYciqUHu8ZUpBo/9sW0jnMDXk 75wSOpJQnKE8WvvqWDftGPQbHgQtJ+9DBVeuc9hb4K0Yu6AGA7K2eJqWPz73WG+G Ycxedd+ZqjCBsRlEWR/jqMsPoGMSHQX9Ku6pqUuMzovF5e5GbsAwaHCv5IxDudRY c9FP05clJDGBQRzAhUe5D/VnqLyyYhiP6i29pqBpFpfC11wPxBm8P/7FipxVADyq dtVtUfGqu3Zr4c3DYazhMmi8cz3sXMzDZxuFYw6Faj+rAywF3nSMDkB0jbqLsSe6 TrcLcU9Wt2J4LRVLIiq9VaDvRpuWHbBCwUHEi13fv8ByG9VNd7CpAoPt168nGZxk 6PefusbUvudMyelF763lfzO1waWRZnjwP24WrsJs/kxNzfkTSUmoVwmymgaCXBMu VKD55c3iqhnfD+bUOao19L+xPXBiYHqrr39FcI/MoLakGeifYKfESNHRtoW67jNw SUk+44WIp65WdrnULLQ71SRevvnxwWM2q2RkASVszEcWnQlhqr8Xmf5Vklt4oeaC M2VxFsP72s75JE2EQsWh =ina2 -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--