Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753243AbdDKDkC (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Apr 2017 23:40:02 -0400
Received: from mail-pg0-f65.google.com ([74.125.83.65]:34253 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753129AbdDKDkA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Apr 2017 23:40:00 -0400
Date: Mon, 10 Apr 2017 20:39:56 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Cc: Henk.Vergonet@gmail.com, usbb2k-api-dev@nongnu.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] input: misc: yealink: define packet offset __be16
 instead of u16
Message-ID: <20170411033956.GD4346@dtor-ws>
References: <1491814577-26408-1-git-send-email-martin.kepplinger@ginzinger.com>
 <1491836422-22309-1-git-send-email-martin.kepplinger@ginzinger.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1491836422-22309-1-git-send-email-martin.kepplinger@ginzinger.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1229
Lines: 43

On Mon, Apr 10, 2017 at 05:00:22PM +0200, Martin Kepplinger wrote:
> sparse says
> 
>  warning: incorrect type in assignment (different base types)
>     expected unsigned short [unsigned] [usertype] offset
>     got restricted __be16 [usertype] <noident>
> 
> for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the
> first place shouldn't hurt.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> Signed-off-by: Henk.Vergonet@gmail.com

Applied, thank you.

> ---
> revision history
> ----------------
> v2: add privately received Signed-off-by
> 
> 
>  drivers/input/misc/yealink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/yealink.h b/drivers/input/misc/yealink.h
> index 1e0f523..934c247 100644
> --- a/drivers/input/misc/yealink.h
> +++ b/drivers/input/misc/yealink.h
> @@ -28,7 +28,7 @@
>  struct yld_ctl_packet {
>  	u8	cmd;		/* command code, see below */
>  	u8	size;		/* 1-11, size of used data bytes. */
> -	u16	offset;		/* internal packet offset */
> +	__be16	offset;		/* internal packet offset */
>  	u8	data[11];
>  	s8	sum;		/* negative sum of 15 preceding bytes */
>  } __attribute__ ((packed));
> -- 
> 2.1.4
> 

-- 
Dmitry