Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbdDKEgS (ORCPT ); Tue, 11 Apr 2017 00:36:18 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:49747 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbdDKEgR (ORCPT ); Tue, 11 Apr 2017 00:36:17 -0400 Subject: Re: [PATCH v1 3/3] nvmem: dt: document SNVS LPGPR binding To: Rob Herring , Oleksij Rempel References: <20170406073107.32445-1-o.rempel@pengutronix.de> <20170406073107.32445-3-o.rempel@pengutronix.de> <20170410182235.pmobyxn6kvyvcwsj@rob-hp-laptop> Cc: Srinivas Kandagatla , Maxime Ripard , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Oleksij Rempel Message-ID: <1e0f8a71-9dca-7aaa-a603-86ed3934da4d@pengutronix.de> Date: Tue, 11 Apr 2017 06:36:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170410182235.pmobyxn6kvyvcwsj@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:13da X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1798 Lines: 54 Hi, On 04/10/2017 08:22 PM, Rob Herring wrote: > On Thu, Apr 06, 2017 at 09:31:07AM +0200, Oleksij Rempel wrote: >> Documenation bindings for the Low Power General Purpose Registe > > s/Registe/Register/ > >> available on i.MX6 SoCs in the Secure Non-Volatile Storage. >> >> Signed-off-by: Oleksij Rempel >> Cc: Srinivas Kandagatla >> Cc: Maxime Ripard >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> --- >> Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt >> >> diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt >> new file mode 100644 >> index 000000000000..9a8be1a2d12e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt >> @@ -0,0 +1,15 @@ >> +Device tree bindings for Low Power General Purpose Registe found in i.MX6Q/D >> +Secure Non-Volatile Storage. >> + >> +Required properties: >> +- compatible: should be one of >> + "fsl,imx6q-snvs-lpgpr" (i.MX6Q/D/DL/S). >> +- offset: Should contain the offset relative to syscon parrent node. > > typo ok. > +- regmap: Should contain a phandle pointing to syscon. >> + >> +Example: >> + snvs_lpgpr: snvs-lpgpr { >> + compatible = "fsl,imx6q-snvs-lpgpr"; >> + regmap = <&snvs>; >> + offset = <0x68>; > > Why does this need to be in DT? Is something going to refer to this > node? If not, the &snvs node should be enough information for the OS. Jes, it is refereed by other driver. Thank you.