Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753306AbdDKGIz (ORCPT ); Tue, 11 Apr 2017 02:08:55 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:60946 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751273AbdDKGIx (ORCPT ); Tue, 11 Apr 2017 02:08:53 -0400 Subject: Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt To: Niklas Cassel , Rob Herring , Mark Rutland , "David S. Miller" , Joao Pinto , Niklas Cassel , Alexandre TORGUE , Thierry Reding , Eric Engestrom References: <20170410074320.9506-1-niklass@axis.com> CC: , , From: Giuseppe CAVALLARO Message-ID: <3a2ab310-adc7-ad66-4094-13e2125734f2@st.com> Date: Tue, 11 Apr 2017 08:08:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170410074320.9506-1-niklass@axis.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG5NODE2.st.com (10.75.127.14) To GPXDAG4NODE4.st.com (10.75.127.74) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-11_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2018 Lines: 47 Hi Niklas On 4/10/2017 9:43 AM, Niklas Cassel wrote: > From: Niklas Cassel > > The hardware has a LPI interrupt. > There is already code in the stmmac driver to parse and handle the > interrupt. However, this information was missing from the DT binding. i wonder if we could improve the comments in this patch too > Signed-off-by: Niklas Cassel > --- > Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index f652b0c384ce..84e4cbfd3b0f 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -8,8 +8,8 @@ Required properties: > that services interrupts for this device > - interrupts: Should contain the STMMAC interrupts > - interrupt-names: Should contain the interrupt names "macirq" > - "eth_wake_irq" if this interrupt is supported in the "interrupts" > - property > + "eth_wake_irq" if this interrupt is supported in the "interrupts" property this is the PMT interrupt to manage the remote wake-up packet detection > + "eth_lpi" if this interrupt is supported in the "interrupts" property This is the interrupt that occurs when Tx or Rx enter/exit from LPI state Regards Peppe > - phy-mode: See ethernet.txt file in the same directory. > - snps,reset-gpio gpio number for phy reset. > - snps,reset-active-low boolean flag to indicate if phy reset is active low. > @@ -152,8 +152,8 @@ Examples: > compatible = "st,spear600-gmac"; > reg = <0xe0800000 0x8000>; > interrupt-parent = <&vic1>; > - interrupts = <24 23>; > - interrupt-names = "macirq", "eth_wake_irq"; > + interrupts = <24 23 22>; > + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; > mac-address = [000000000000]; /* Filled in by U-Boot */ > max-frame-size = <3800>; > phy-mode = "gmii";