Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753388AbdDKGhc (ORCPT ); Tue, 11 Apr 2017 02:37:32 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:58249 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbdDKGhb (ORCPT ); Tue, 11 Apr 2017 02:37:31 -0400 Subject: Re: [PATCH v2 1/3] cpufreq: Add Tegra186 cpufreq driver To: Viresh Kumar , Mikko Perttunen References: <1491313417-25085-1-git-send-email-mperttunen@nvidia.com> <20170411063548.GD3670@vireshk-i7> Cc: rjw@rjwysocki.net, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org From: Mikko Perttunen Message-ID: Date: Tue, 11 Apr 2017 09:37:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170411063548.GD3670@vireshk-i7> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 84.249.193.183 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 35 On 04/11/2017 09:35 AM, Viresh Kumar wrote: > On 04-04-17, 16:43, Mikko Perttunen wrote: >> Add a new cpufreq driver for Tegra186 (and likely later). >> The CPUs are organized into two clusters, Denver and A57, >> with two and four cores respectively. CPU frequency can be >> adjusted by writing the desired rate divisor and a voltage >> hint to a special per-core register. >> >> The frequency of each core can be set individually; however, >> this is just a hint as all CPUs in a cluster will run at >> the maximum rate of non-idle CPUs in the cluster. >> >> Signed-off-by: Mikko Perttunen >> --- >> v2: >> - Many cosmetic / restructuring changes >> - Only one aperture read from DT now, with a new >> structure containing the offset among other details >> per cluster. >> - Don't enable the driver by default. >> >> drivers/cpufreq/Kconfig.arm | 6 + >> drivers/cpufreq/Makefile | 1 + >> drivers/cpufreq/tegra186-cpufreq.c | 275 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 282 insertions(+) >> create mode 100644 drivers/cpufreq/tegra186-cpufreq.c > > For all three patches. > > Acked-by: Viresh Kumar > Thanks! Mikko