Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753875AbdDKHNe (ORCPT ); Tue, 11 Apr 2017 03:13:34 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34587 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbdDKHMr (ORCPT ); Tue, 11 Apr 2017 03:12:47 -0400 Date: Tue, 11 Apr 2017 09:12:42 +0200 From: Ingo Molnar To: "Kirill A. Shutemov" Cc: Denys Vlasenko , brgerst@gmail.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, luto@amacapital.net, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, luto@kernel.org, peterz@infradead.org, bp@alien8.de, hpa@zytor.com, dave.hansen@intel.com, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/mm] x86/asm: Remove __VIRTUAL_MASK_SHIFT==47 assert Message-ID: <20170411071242.GA23772@gmail.com> References: <20170330080731.65421-3-kirill.shutemov@linux.intel.com> <53f40ad7-2775-517f-91d1-bde811697045@redhat.com> <20170405111258.5ro7momzscweinuf@black.fi.intel.com> <20170405120029.ckl2a5bc3ikydozw@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170405120029.ckl2a5bc3ikydozw@black.fi.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 32 * Kirill A. Shutemov wrote: > On Wed, Apr 05, 2017 at 01:50:27PM +0200, Denys Vlasenko wrote: > > Er.... "Change top bits ... ((47 or 56 [bits] depending on paging mode)"? > > I know that's wrong and that's not what you meant to say, > > but it can be read this way too. "47th" instead of "47" > > would eliminate this reading, but you removed "th". > > > > Spell it out to eliminate any chance of confusion: > > > > Change top bits to match most significant bit (47th or 56th bit > > depending on paging mode) in the address. > > > > ---------------------8<----------------------- > > From 5dec28ba49387ff444e447213b553506e253616d Mon Sep 17 00:00:00 2001 > From: "Kirill A. Shutemov" > Date: Wed, 5 Apr 2017 14:06:15 +0300 > Subject: [PATCH] x86/asm: Fix comment in return_from_SYSCALL_64 > > On x86-64 __VIRTUAL_MASK_SHIFT depends on paging mode now. > > Signed-off-by: Kirill A. Shutemov Could you please integrate this into your series to make sure I apply all the intended+latest bits? Thanks, Ingo