Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbdDKIJh (ORCPT ); Tue, 11 Apr 2017 04:09:37 -0400 Received: from mail-eopbgr30090.outbound.protection.outlook.com ([40.107.3.90]:26592 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752010AbdDKII2 (ORCPT ); Tue, 11 Apr 2017 04:08:28 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting To: References: <1491208718-32068-1-git-send-email-peda@axentia.se> CC: Wolfram Sang , Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , , , From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <5f70e59b-f832-f123-6901-ab89b45e7d70@axentia.se> Date: Tue, 11 Apr 2017 10:08:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491208718-32068-1-git-send-email-peda@axentia.se> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0073.eurprd07.prod.outlook.com (10.165.201.31) To AM5PR0202MB2548.eurprd02.prod.outlook.com (10.173.89.9) X-MS-Office365-Filtering-Correlation-Id: a4f576ef-60ac-4021-c4b4-08d480b1eda5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;3:pNQQ/8frI27REWku4hn642lkDNCSw3TXaO1foOjmDhs4OVWc6V1NQot0eNqsMad/h1ABu3mTTKw6RHgoUQtvExq0ivp+qyQwUuP+ski5s02ik5B2uOyeCCnBuMp8tmovcYvWECgglyRSAXxy3xGiws+kjbH6eLKgIkCjysiQoJBpZDfPMSAREPG9nt2to4fLQFnva55b3K6vf6JZP6tqFMhfq5z0BILkoFgcfOzAOxV9CN5A+9DZVE3caQQeLsgg95xpSUmjOlVJMJ34KtkE2cuAAPNAFJ9dWdiLsIaGgjw=;25:KblT7cEtQiEvMQdRPgNoUSXgGlP6umINKWKsDqCqdO2Zrz1qThs5FlLMhXO2ViCFLsiG+HsYa+QYjuD2Gd5bCFBTK5jcPk2RceS1Fx99n53jw6T0OOSnwXOSCPC+GV0LzOz0B0cEynLNA1XKPOT5hPe1t56IgdEWVq2xrcmeGWurYax5m0FLvaHhTjcMqy0gaHYaK1gujREzj3RtN28juEwhc9pJatdAV6q/EsD7zdp/CFxBfkX1C43KlcZzjzMYwi8EzkwhRgjDmxaPOQUyEBj0auZnnWbe4RPGljPm/nuXEtmEVYLzntV7kgVnHY0QGK1oloJVixC8fzx0ACG/1AGXoiI49CFMMoJ4PLjPVsGEBZtLfq0oA2crMoWR/D8ydreQ/9b8drYc4nAOncdTz3IBWIn4Q65aJYTQEUxle8+2NWaJSId3hs53/Odu/q9wJUNGXgtbT5YmDjFxuW5CuQ== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;31:6s0xFNlPK+XgCpTObNJ4wYktXbY3Zgna6xYYCzKyWnGOAgBdwid5wCd9mMiy4DcVWYFOdGreo3/XP1eowuvGSi3GP4x7oMkFcV2Cmpd7HYcKSgNK2tWh80UTqSuqdtKVCb7Jp5M3xbMXrheyHHJ0A5OZ3CEJ2N4kPAH0uNeIdcWPtWMVj8OdLznkJUC9skU+YG7x1klYqrGlmdye2ihkLtMfF3Oaj0qvBPB6k/AgIAXPAV1SiROt5hNYN5rm2+qFZaxfqaAuUQWo7dmewGeixg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(2016111802025)(20161123555025)(20161123564025)(6072148)(6043046);SRVR:AM5PR0202MB2548;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;4:gh9rLZcBTwb/fgfd+1XTO2vdYOnXUP2iaunXBQTNmlKNE1auk7BTufTr/Vo/BJgGO7T69fvKtsW9ZrNpgSJ9e4bmY20zUoFO7ASpekWp6AJJ/6ZwGa+y54afKM7k2stzkHG0cXv5ubyZC7EpxzeHobIJQMEM/AeeU24hDnvyt4h+Shi1cgPm9ZBI2wmHRN32x1fPIGqJwKV0PMN/7wJ3Mmk5gJue1whvENSKMprzCQ3Yo5WfC7JO6hm3I3jIEagkkXhukX6a90tWJdVSt3T4tHqFXSoe3AVWhXV+wkyPd7nBp2WY84WsWR2hpr3i72+5uI6t/Oo/Q0k24VfhC+iuXxYXSH/G4WjA8hKkLmAzJw1acIWtTmw7IFU5Jk7U2Rb8E/+j+DJzxi5KCsuACpb9mHyZycN/iuNOd0660X+gdrrMRG3nHfMUlKSW4QrkoKACjBeox9mrjjednxJ59bm1uGnBSMHy/GB8WdGUmjtmH8nSILj5JMj2e9/XGrO+jV99/yyjmCFX84qMbTn4Jy+MNcdJEdcBEbUMgh/X5oYh/IDvdf4/Jd5gXthgYLvn/WL9V/NqxbiU/jAyMDYl6q61/143S8f8RtN7tAPr/7jhem1+CmF0ruAhuwJDSzyyiUn1NDX4cNc+aZ52A4lquz6zTH/xOLBtgY1cDHzcSGKIpoSONpAgMa8Ig/daWqlMS1/M9VwNr4TQV+aTEivNzPG8HGXbwSQNAxn4aHBXs0U79xuDc86q4l/+iXpiHc4ab7m0u5Yg/wmVVp/KXQEkA969n9GNABxvzWp+8VIqG5TmGW0o8M+U2MQTWePzP2ydWEU3 X-Forefront-PRVS: 0274272F87 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39830400002)(39410400002)(39400400002)(39450400003)(377424004)(24454002)(110136004)(36756003)(6246003)(38730400002)(6486002)(8676002)(189998001)(81166006)(117156002)(5660300001)(4001350100001)(3846002)(90366009)(6116002)(230700001)(2351001)(6666003)(305945005)(83506001)(7416002)(23746002)(86362001)(7736002)(8666007)(64126003)(6916009)(229853002)(77096006)(54906002)(31696002)(2950100002)(50466002)(53936002)(74482002)(65806001)(66066001)(47776003)(65956001)(31686004)(2906002)(42186005)(76176999)(54356999)(50986999)(65826007)(4326008)(33646002)(53546009)(25786009)(3260700006)(15760500002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0202MB2548;H:[192.168.0.125];FPR:;SPF:None;MLV:nov;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0202MB2548;23:62K/DN63T4/ZjBAN8o1Nu6CLoCu9jq2OLv4?= =?Windows-1252?Q?RQYxBlurIWJAAMKi1q54BQF2Ar1T6giuHdd2qj9o9Cq47IpBFwLW5JKV?= =?Windows-1252?Q?9S8dKalZM9N4A/EbTmLxQvsn6VnL9mQvKlVyHAs+5lURll/SxC+2m8gr?= =?Windows-1252?Q?VSD4eb3EmpFFkK3GYDWJaivwMPyX68SxnnS1ZeOZk/A+bhbI6/sLz4q9?= =?Windows-1252?Q?/ZzzHbJQJ1wTqx5rHnRBveOYV72wk3hEmgJBf/sSp/OWP3UxQeHUt4wh?= =?Windows-1252?Q?UNR67ED5YY31X1nRMm8mGkcVM8i1g334cEAQ7bojXjfOs1JGVB8kpOlE?= =?Windows-1252?Q?IHh1m3Qc7zjfPMtowmoyLfe3pyWHriQj60k66RnYB++o/8T+sz5LyItc?= =?Windows-1252?Q?kog54Q8SC7i+l1kXIFrWUOb2OGNSYSkNh5K0tEFrM4Sp+fzpIEVn7GTu?= =?Windows-1252?Q?+XpMPoZ87iyjsHUFxwAqC6eMb6hoZynVWTblofMPeGRrnW7L8ZuAPY7D?= =?Windows-1252?Q?0l8oayzn4oaKKfwZnIVDlsF7FN/SxDiNnO3N34urHmIBUIj4XsTmOQv3?= =?Windows-1252?Q?W+r5EcVASLomQZK6vc3AdWS2xszStQKNY6iZNUPuotEeG26jGn3Nsm6S?= =?Windows-1252?Q?UG3XdmpPoe53ZNDgRKM4iucL32A+ilft4JO4Z3DcHdLo8D5gCPy3SHTK?= =?Windows-1252?Q?cpRZqVhPNKKhtmiY0U8qMwFT3TDzxwgc8bIeYbIgmojt11Lknt1TAt4J?= =?Windows-1252?Q?RvOVqbed7wwQP0jjRy/PLQQjxUSfkC0LvpVEWiBPovT9RGzokjiEn/f5?= =?Windows-1252?Q?6oktw/5xQTK55XnnNteBY0ktv+Wgiwu0iDUnWO+59jnhSOTuvPnuF7Rh?= =?Windows-1252?Q?rVpFICBz7+xYFYBxxTr5s/glzkt+WyIjWPqC6MbLkT96c0OjJHGrd01n?= =?Windows-1252?Q?evIBL3oHqkcr/o6+XAn28W4mCH8vbn9JzxpLlpOiijZtFkjdPgxFgDtq?= =?Windows-1252?Q?NiPGD35SteTdysJw8VuhsDoNXYn5LGZVbfDvJOrBrUyw2sVFrVn0iKZP?= =?Windows-1252?Q?2jBeyK5T3Hg9aFn58z7bd9AnyUm4aGiWS1pgrQOKRV3hERaNyoVs5mEZ?= =?Windows-1252?Q?F+SuL2g2nr6fvy8GY3ISc02k4u2rZKlTeisVABfZcPSOlKiSvIxI6I8J?= =?Windows-1252?Q?+vW+4nPqAD44f6o/PFRjRSdKWPGNKD+WCZHe0Au+z7oidxx+RhAe/pSG?= =?Windows-1252?Q?F/lTGZo6tVsVgoTb46Oexuk/zastuKwgo32UoAKjUQ5NvTCULJbamCsN?= =?Windows-1252?Q?lQ6i0SriBlsjp5AwUzTbq15CyPLKK48Gcs9a5WvgDxPpTmYLYZ6kvN6y?= =?Windows-1252?Q?cfgYT0Fa9LPWPrlfAkehf1DMkiq7rZ77U79MfcdXQ/AU54drkRr80GM2?= =?Windows-1252?Q?tiKChMaAU4Q/+BOvnO01K9nBChkL6nMc+TSr7x5C2UEmuHCyHmt/sgVb?= =?Windows-1252?Q?L/NoJIEu3aQTH4Bh/HNTwXSo+WNFO6BT+Q/Ib39PaX1gXxNesYyGTr68?= =?Windows-1252?Q?rb5GoQ0YwrYNRiqt5M7vpFf0dS3An1dMPVLG6?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;6:BI/pjIHJCw+kJMa/A8M5L5GTTcc8/vQh7gznj+pUNQh5alH+7qdk+XxJlI8JRMZuQ6nuEyMmDIIVjImwYXpW57jmEcYKx0ljtqBuTBAeIa3jGCgGj9Z/OUaM8vbeQT4+eYNfvtUFXsJeup3hgp+JAhsIY6S7W8zeiaCHXmT0bc+83Thoh+yuFn0Ozci7ni/6FGG6r3ZyITAaJ7/zzdpXOrX3t41djNZi3vsd+o5OOqrAOEnhInH/oAsAWaXUQ3R7RuWBmKDeJA8i3c39/G1My5erY1EA7OnzydhbbJC5fpt+xqUUTNmTlFlwgEikdGiVj4BV+SBUJZDvjIlMDLgAwYi5M1cvUNyOgA1GFAhxL3yKqXCRd3Sfd+8IElGh2DUSsINqNhnNvnVKQCATtAfGBZZ97GrC9BLhLWJym9zqTggWJV1F92+ERouQb8km2pFQy0kMHIyhlbP6qCn+qk+/zw==;5:fzeE2QEAidl/l9LnyR8T1Y02qwV5vWFfOAsUkhVGRugl98Q91etXnEiH4+gUJ637Ti/jpiMpbjHXyt8ZiGaRGl6ka8QRXgfMtiEqgJFYByKjm1G+EjOBOnljGGdo05EuRXh4gbJM6/xXnnivwtNUNw==;24:7Mft3IF/AOm6XBc/6we7Lmvt/hRzkFFHADw4z8iTpBC/0aQpiZLFXkYDGmwWqelveYsVxplURn8eBl0qslGGHeBog8xEKv633cIsb2hYVIM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;7:cXxWAg/kuuk5fvZip/d1R9DNsdmEerSSmTV3yHxWon1A/wO216jH55oSQNDdDCmx8MyS0idhi6pi8aVvSXpAFOI3YMU4fiQG6uSa06h0Scb5xQC0EokJF6Ho8u8YOHP6yDmEjE1UGhPeqAFEUZKczIkyosr7hgXsOo7suHJ44CdWN/22PmjnqliLzlBgek4L2nHN/v2bV+j5YVuMsc9xDbEu8ZfCKvXSnGNdf3YTx59Jb9+fNwbuZ+d6d5ViMOhBsylVWeu8nfRcGoit0iR1uczaJgyLXgmpXebOSlcwCpqKdrxRUyJ2gxVq97YqH3aNik8EoEYZi4D1PVA+MsjOwA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2017 08:08:24.0795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0202MB2548 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1734 Lines: 45 On 2017-04-03 10:38, Peter Rosin wrote: > Hi! > > Many users of the i2c_mux_add_adapter interface log a message > on failure, but the function already logs such a message. One > or two of those users actually add more information than already > provided by the central failure message. > > So, first fix the central error reporting to provide as much > information as any current user, and then remove the surplus > error reporting at the call sites. I have now pushed patches 1-7 to i2c-mux/for-next. Jonathan grabbed patch 8 and it's going through the iio tree. Still waiting on patch 9 and the media maintainers. Cheers, Peter > > Cheers, > peda > > Peter Rosin (9): > i2c: mux: provide more info on failure in i2c_mux_add_adapter > i2c: arb: gpio-challenge: stop double error reporting > i2c: mux: gpio: stop double error reporting > i2c: mux: pca9541: stop double error reporting > i2c: mux: pca954x: stop double error reporting > i2c: mux: pinctrl: stop double error reporting > i2c: mux: reg: stop double error reporting > iio: gyro: mpu3050: stop double error reporting > [media] cx231xx: stop double error reporting > > drivers/i2c/i2c-mux.c | 9 ++++++--- > drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 4 +--- > drivers/i2c/muxes/i2c-mux-gpio.c | 4 +--- > drivers/i2c/muxes/i2c-mux-pca9541.c | 4 +--- > drivers/i2c/muxes/i2c-mux-pca954x.c | 7 +------ > drivers/i2c/muxes/i2c-mux-pinctrl.c | 4 +--- > drivers/i2c/muxes/i2c-mux-reg.c | 4 +--- > drivers/iio/gyro/mpu3050-i2c.c | 5 ++--- > drivers/media/usb/cx231xx/cx231xx-i2c.c | 15 ++++----------- > 9 files changed, 18 insertions(+), 38 deletions(-) >