Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbdDKILN (ORCPT ); Tue, 11 Apr 2017 04:11:13 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34712 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbdDKILI (ORCPT ); Tue, 11 Apr 2017 04:11:08 -0400 Message-ID: <1491898253.8380.2.camel@gmail.com> Subject: Re: [PATCH 1/9] mm: remove return value from init_currently_empty_zone From: Balbir Singh To: Michal Hocko , linux-mm@kvack.org Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko Date: Tue, 11 Apr 2017 18:10:53 +1000 In-Reply-To: <20170410110351.12215-2-mhocko@kernel.org> References: <20170410110351.12215-1-mhocko@kernel.org> <20170410110351.12215-2-mhocko@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 472 Lines: 15 On Mon, 2017-04-10 at 13:03 +0200, Michal Hocko wrote: > From: Michal Hocko > > init_currently_empty_zone doesn't have any error to return yet it is > still an int and callers try to be defensive and try to handle potential > error. Remove this nonsense and simplify all callers. > > This patch shouldn't have any visible effect > > Signed-off-by: Michal Hocko > --- This makes sense Acked-by: Balbir Singh