Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754012AbdDKISh (ORCPT ); Tue, 11 Apr 2017 04:18:37 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:35856 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbdDKISA (ORCPT ); Tue, 11 Apr 2017 04:18:00 -0400 MIME-Version: 1.0 In-Reply-To: <1491895862-7952-1-git-send-email-richard.leitner@skidata.com> References: <1491895862-7952-1-git-send-email-richard.leitner@skidata.com> From: Linus Walleij Date: Tue, 11 Apr 2017 10:17:58 +0200 Message-ID: Subject: Re: [PATCH v2] mmc: core: add mmc-card hardware reset enable support To: Richard Leitner , Bart Van Assche , Luca Porzio Cc: Ulf Hansson , Rob Herring , Mark Rutland , Shawn Lin , Adrian Hunter , Jaehoon Chung , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Richard Leitner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 848 Lines: 23 On Tue, Apr 11, 2017 at 9:31 AM, Richard Leitner wrote: > Some eMMCs disable their hardware reset line (RST_N) by default. To enable > it the host must set the corresponding bit in ECSD. An example for such > a device is the Micron MTFCxGACAANA-4M. > > This patch adds a new mmc-card devicetree property to let the host enable > this feature during card initialization. > > Signed-off-by: Richard Leitner Do we know *WHY* these cards disable their hardware reset lines? If it is just some random over-cautious panic thing we might consider just force re-enableing it, maybe with a warning in the dmesg, so we can always reset the card. No DT property needed. Putting some people who work for eMMC vendors in the To: line so they can say if they know about this. Yours, Linus Walleij