Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754274AbdDKJAT (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Apr 2017 05:00:19 -0400
Received: from ozlabs.org ([103.22.144.67]:41857 "EHLO ozlabs.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754203AbdDKJAP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Apr 2017 05:00:15 -0400
From: Michael Ellerman <mpe@ellerman.id.au>
To: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
        Sachin Sant <sachinp@linux.vnet.ibm.com>, linuxppc-dev@ozlabs.org
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: WARN @lib/refcount.c:128 during hot unplug of I/O adapter.
In-Reply-To: <89aec36c-e352-e055-5e80-1235449762ce@linux.vnet.ibm.com>
References: <E5B3D5CE-EB6A-4470-B7E9-4F6F7B029809@linux.vnet.ibm.com> <a7a782f2-3783-fd96-eda9-1c7634b2a2e5@linux.vnet.ibm.com> <8760ig983f.fsf@concordia.ellerman.id.au> <89aec36c-e352-e055-5e80-1235449762ce@linux.vnet.ibm.com>
User-Agent: Notmuch/0.21 (https://notmuchmail.org)
Date: Tue, 11 Apr 2017 19:00:08 +1000
Message-ID: <871sszwc87.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1314
Lines: 38

Tyrel Datwyler <tyreld@linux.vnet.ibm.com> writes:

> On 04/06/2017 09:04 PM, Michael Ellerman wrote:
>> Tyrel Datwyler <tyreld@linux.vnet.ibm.com> writes:
>> 
>>> On 04/06/2017 03:27 AM, Sachin Sant wrote:
>>>> On a POWER8 LPAR running 4.11.0-rc5, a hot unplug operation on
>>>> any I/O adapter results in the following warning
>>>>
>>>> This problem has been in the code for some time now. I had first seen this in
>>>> -next tree.
>>>>
>
> <snip>
>
>>>> Have attached the dmesg log from the system. Let me know if any additional
>>>> information is required to help debug this problem.
>>>
>>> I remember you mentioning this when the issue was brought up for CPUs. I
>>> assume the case is the same here where the issue is only seen with
>>> adapters that were hot-added after boot (ie. hot-remove of adapter
>>> present at boot doesn't trip the warning)?
>> 
>> So who's fixing this?
>
> I started looking at it when Bharata submitted a patch trying to fix the
> issue for CPUs, but got side tracked by other things. I suspect that
> this underflow has actually been an issue for quite some time, and we
> are just now becoming aware of it thanks to the recount_t patchset being
> merged.

Yes I agree. Which means it might be broken in existing distros.

> I'll look into it again this week.

Thanks.

cheers