Message-ID: <87k26rti8s.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
CC: Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 2/2] clk: cs2000: add AUX_OUT pin select support
In-Reply-To: <CAMuHMdU=8yRF9GggrM7wiFhZckAH-caso=6nL1sELXpykqLp6g@mail.gmail.com>
References: <87fuhfyedq.wl%kuninori.morimoto.gx@renesas.com>
        <87d1cjyeb4.wl%kuninori.morimoto.gx@renesas.com>
        <CAMuHMdU=8yRF9GggrM7wiFhZckAH-caso=6nL1sELXpykqLp6g@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Tue, 11 Apr 2017 09:22:26 +0000
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2017 09:22:26.4777 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0831
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 889
Lines: 27


Hi Geert

Thank you for your feedback

> > +- auxoutsrc:           select AUX_OUT source from these.
> > +                               refclk:         Timing Reference Clock
> > +                               clk_in:         Frequency Reference Clock
> > +                               pllclkout:      PLL Clock Output
> > +                               push-pull:      PLL Lock/Unlock Indication
> > +                               open-drain:     PLL Lock/Unlock Indication
> 
> AUX_OUT is an output pin?
> Hence, isn't this software configuration instead of hardware description?
> 
> Selection of refclk vs. clk_in vs. pllclkout can be implemented as a mux clock
> driver with three parents.
> 
> PLL Lock/Unlock Indication and its pinctrl are something different.
> How to support that?

I think mux clock is nice idea.
I will use this idea.

Best regards
---
Kuninori Morimoto