Date: Tue, 11 Apr 2017 10:35:31 +0100
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Gustavo Padovan <gustavo.padovan@collabora.com>
Subject: Re: [PATCH 3/3] drm/vc4: Add support for dma-buf fencing.
Message-ID: <20170411093531.GY6834@nuc-i3427.alporthouse.com>
Mail-Followup-To: Chris Wilson <chris@chris-wilson.co.uk>,
        Eric Anholt <eric@anholt.net>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        Gustavo Padovan <gustavo.padovan@collabora.com>
References: <20170411014414.20280-1-eric@anholt.net>
 <20170411014414.20280-3-eric@anholt.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170411014414.20280-3-eric@anholt.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 886
Lines: 25

On Mon, Apr 10, 2017 at 06:44:14PM -0700, Eric Anholt wrote:
> This is needed for proper synchronization with display on another DRM
> device (pl111 or tinydrm) with buffers produced by vc4 V3D.  Fixes the
> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2
> desktop tests on pl111+vc4.
> 
> This doesn't yet introduce waits on other device's fences before vc4's
> rendering/display, because I don't have testcases for them.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
> ---
> +static void vc4_fence_release(struct dma_fence *fence)
> +{
> +	struct vc4_fence *f = to_vc4_fence(fence);
> +
> +	kfree_rcu(f, base.rcu);
> +}

Unless you have a plan to do more here, looks like you can just use
the default dma_fence_free as the release callback.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre