Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754557AbdDKJgU (ORCPT ); Tue, 11 Apr 2017 05:36:20 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34255 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753980AbdDKJgT (ORCPT ); Tue, 11 Apr 2017 05:36:19 -0400 MIME-Version: 1.0 In-Reply-To: <005a0edf-6d5e-e9c0-6f93-3d08a41cb24a@oracle.com> References: <20170312093820.12044-1-vegard.nossum@oracle.com> <005a0edf-6d5e-e9c0-6f93-3d08a41cb24a@oracle.com> From: Vegard Nossum Date: Tue, 11 Apr 2017 11:36:16 +0200 Message-ID: Subject: Re: [PATCH] um: use KERN_CONT in stack dump To: Vegard Nossum Cc: Richard Weinberger , user-mode-linux-devel , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 24 On 12 March 2017 at 10:47, Vegard Nossum wrote: > On 12/03/2017 10:45, Richard Weinberger wrote: >> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c >> index aa1b56f5ac68..18eddf677ec6 100644 >> --- a/arch/um/kernel/sysrq.c >> +++ b/arch/um/kernel/sysrq.c >> @@ -17,10 +17,8 @@ >> >> static void _print_addr(void *data, unsigned long address, int reliable) >> { >> - pr_info(" [<%08lx>]", address); >> - pr_cont(" %s", reliable ? "" : "? "); >> - print_symbol("%s", address); >> - pr_cont("\n"); >> + pr_info(" [<%08lx>] %s%pB\n", address, reliable ? "" : "? ", >> + (void *)address); >> } > > Tested-by: Vegard Nossum Just a heads up, this still appears unfixed in Linus's repo. Vegard