Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754614AbdDKJhx (ORCPT ); Tue, 11 Apr 2017 05:37:53 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:50776 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125AbdDKJhu (ORCPT ); Tue, 11 Apr 2017 05:37:50 -0400 Date: Tue, 11 Apr 2017 10:37:37 +0100 From: Russell King - ARM Linux To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111 Message-ID: <20170411093737.GV17774@n2100.armlinux.org.uk> References: <20170411011801.15788-1-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170411011801.15788-1-eric@anholt.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 548 Lines: 14 On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: > v5: Move register definitions inside the driver directory, fix build > in COMPILE_TEST and !AMBA mode. Why is it necessary to move the register definitions there, when they're already available in linux/amba/clcd.h and are required for the FB driver? It is absurd to have driver specific register definitions. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.