Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753630AbdDKJzO (ORCPT ); Tue, 11 Apr 2017 05:55:14 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:36061 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbdDKJzL (ORCPT ); Tue, 11 Apr 2017 05:55:11 -0400 Date: Tue, 11 Apr 2017 10:55:07 +0100 From: Lee Jones To: Tony Lindgren Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Charles Keepax , Marcel Partap , Michael Scott , Sebastian Reichel Subject: Re: [PATCH 3/3] mfd: cpcap: Fix bad use of IRQ sense register Message-ID: <20170411095507.3nfabfqx2rz45uft@dell> References: <20170404031556.5093-1-tony@atomide.com> <20170404031556.5093-4-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170404031556.5093-4-tony@atomide.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 37 On Mon, 03 Apr 2017, Tony Lindgren wrote: > The cpcap INTS registers are for getting the value of the line, > not for configuring the type. > > Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support") > Cc: Charles Keepax > Cc: Marcel Partap > Cc: Michael Scott > Cc: Sebastian Reichel > Reviewed-By: Sebastian Reichel > Tested-by: Sebastian Reichel > Acked-by: Lee Jones > Signed-off-by: Tony Lindgren > --- > drivers/mfd/motorola-cpcap.c | 1 - > 1 file changed, 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c > --- a/drivers/mfd/motorola-cpcap.c > +++ b/drivers/mfd/motorola-cpcap.c > @@ -88,7 +88,6 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = { > .status_base = CPCAP_REG_INT1, > .ack_base = CPCAP_REG_INT1, > .mask_base = CPCAP_REG_INTM1, > - .type_base = CPCAP_REG_INTS1, > .use_ack = true, > .ack_invert = true, > }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog