Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754193AbdDKKUR (ORCPT ); Tue, 11 Apr 2017 06:20:17 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35069 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754054AbdDKKUO (ORCPT ); Tue, 11 Apr 2017 06:20:14 -0400 MIME-Version: 1.0 In-Reply-To: References: <1490864181-2192-1-git-send-email-richard@nod.at> <4c7a176b-6132-7936-a04f-d4def5e56320@nod.at> <646ae733-5037-3072-7151-b055a8fa1521@intel.com> <92bbb4d1-afe7-14f2-763b-051c7b12ff9e@nod.at> From: Amir Goldstein Date: Tue, 11 Apr 2017 13:20:13 +0300 Message-ID: Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Richard Weinberger Cc: Adrian Hunter , linux-mtd@lists.infradead.org, linux-kernel , Artem Bityutskiy , "stable [v4.9]" , Ralph Sennhauser Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 28 On Thu, Apr 6, 2017 at 3:26 PM, Richard Weinberger wrote: > Am 06.04.2017 um 14:09 schrieb Richard Weinberger: >>> Were you able to make any progress? still working on this? >>> If this is too complicated to get in for this cycle, better send a patch >>> to disable O_TMPFILE support for ubifs and fix the problem properly on >>> followup merge cycle. >>> Because right now ubifs O_TMPFILE support is broken and breaks overlayfs mount. >> >> I have a test and currently testing it. As it looks the situation is less worse >> than I thought first. :-) > > s/test/patch :) > Richard, Maybe it's not my business to interfere with ubifs development and I haven't seen your patch. But on the face of it, it doesn't sound like fixing O_TMPFILE is a trivial fix, so not sure it is wise to send a patch for -rc7?... How about sending the patch to disable O_TMPFILE for -rc7 and queuing your fix for v4.12? Without any patch, v4.11 is going to have a regression with overlayfs+ubifs. Amir.