Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754590AbdDKKrZ (ORCPT ); Tue, 11 Apr 2017 06:47:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:33215 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbdDKKrV (ORCPT ); Tue, 11 Apr 2017 06:47:21 -0400 Date: Tue, 11 Apr 2017 12:47:10 +0200 From: Michal Hocko To: Igor Mammedov Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Vitaly Kuznetsov , LKML , Dan Williams , Heiko Carstens , Lai Jiangshan , Martin Schwidefsky , Tobias Regnery Subject: Re: [PATCH -v2 0/9] mm: make movable onlining suck less Message-ID: <20170411104710.GF6729@dhcp22.suse.cz> References: <20170410110351.12215-1-mhocko@kernel.org> <20170410162749.7d7f31c1@nial.brq.redhat.com> <20170410145639.GE4618@dhcp22.suse.cz> <20170411100152.6b4be896@nial.brq.redhat.com> <20170411084142.GB6729@dhcp22.suse.cz> <20170411115322.669c435d@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170411115322.669c435d@nial.brq.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 42 On Tue 11-04-17 11:53:22, Igor Mammedov wrote: > On Tue, 11 Apr 2017 10:41:42 +0200 > Michal Hocko wrote: > > > On Tue 11-04-17 10:01:52, Igor Mammedov wrote: > > > On Mon, 10 Apr 2017 16:56:39 +0200 > > > Michal Hocko wrote: > > [...] > > > > > #echo online_kernel > memory32/state > > > > > write error: Invalid argument > > > > > // that's not what's expected > > > > > > > > this is proper behavior with the current implementation. Does anything > > > > depend on the zone reusing? > > > if we didn't have zone imbalance issue in design, > > > the it wouldn't matter but as it stands it's not > > > minore issue. > > > > > > Consider following, > > > one hotplugs some memory and onlines it as movable, > > > then one needs to hotplug some more but to do so > > > one one needs more memory from zone NORMAL and to keep > > > zone balance some memory in MOVABLE should be reonlined > > > as NORMAL > > > > Is this something that we absolutely have to have right _now_? Or are you > > OK if I address this in follow up series? Because it will make the > > current code slightly more complex and to be honest I would rather like > > to see this "core" merge and build more on top. > > It's fine by me to do it on top. OK, I will document this in the changelog of the patch 6. " Please note that this patch also changes the original behavior when offlining a memory block adjacent to another zone (Normal vs. Movable) used to allow to change its movable type. This will be handled later. " -- Michal Hocko SUSE Labs