Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754714AbdDKMD3 (ORCPT ); Tue, 11 Apr 2017 08:03:29 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35382 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbdDKMDX (ORCPT ); Tue, 11 Apr 2017 08:03:23 -0400 Date: Tue, 11 Apr 2017 13:03:19 +0100 From: Lee Jones To: Marek Szyprowski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Krzysztof Kozlowski , Linus Walleij , Tomasz Figa , Bartlomiej Zolnierkiewicz , Chanwoo Choi Subject: Re: [PATCH v4 5/6] mfd: exynos-lpass: Add missing remove() function Message-ID: <20170411120319.wzdl5spygk5ugmww@dell> References: <1490256207-10061-1-git-send-email-m.szyprowski@samsung.com> <1490256207-10061-6-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1490256207-10061-6-git-send-email-m.szyprowski@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 49 On Thu, 23 Mar 2017, Marek Szyprowski wrote: > Disable device on driver remove and release allocated regmap. > > Signed-off-by: Marek Szyprowski > Reviewed-by: Krzysztof Kozlowski > Acked-by: Sylwester Nawrocki > Acked-for-MFD-by: Lee Jones > --- > drivers/mfd/exynos-lpass.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c > index be264988bdc9..9dbbedad916f 100644 > --- a/drivers/mfd/exynos-lpass.c > +++ b/drivers/mfd/exynos-lpass.c > @@ -137,6 +137,16 @@ static int exynos_lpass_probe(struct platform_device *pdev) > return of_platform_populate(dev->of_node, NULL, NULL, dev); > } > > +static int exynos_lpass_remove(struct platform_device *pdev) > +{ > + struct exynos_lpass *lpass = platform_get_drvdata(pdev); > + > + exynos_lpass_disable(lpass); > + regmap_exit(lpass->top); > + > + return 0; > +} > + > static int __maybe_unused exynos_lpass_suspend(struct device *dev) > { > struct exynos_lpass *lpass = dev_get_drvdata(dev); > @@ -171,6 +181,7 @@ static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, > .of_match_table = exynos_lpass_of_match, > }, > .probe = exynos_lpass_probe, > + .remove = exynos_lpass_remove, > }; > module_platform_driver(exynos_lpass_driver); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog