Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbdDKMnN (ORCPT ); Tue, 11 Apr 2017 08:43:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:42209 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbdDKMnJ (ORCPT ); Tue, 11 Apr 2017 08:43:09 -0400 Subject: Re: [PATCH v6] kvm: better MWAIT emulation for guests To: "Gabriel L. Somlo" References: <1491911135-216950-1-git-send-email-agraf@suse.de> <20170411124109.GB29540@HEDWIG.INI.CMU.EDU> Cc: kvm list , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jim Mattson , "Michael S. Tsirkin" , LKML , Paolo Bonzini , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Joerg Roedel , linux-doc@vger.kernel.org, qemu-devel@nongnu.org From: Alexander Graf Message-ID: Date: Tue, 11 Apr 2017 14:43:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170411124109.GB29540@HEDWIG.INI.CMU.EDU> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 47 On 04/11/2017 02:41 PM, Gabriel L. Somlo wrote: > On Tue, Apr 11, 2017 at 01:45:35PM +0200, Alexander Graf wrote: >> From: "Michael S. Tsirkin" >> >> Guests that are heavy on futexes end up IPI'ing each other a lot. That >> can lead to significant slowdowns and latency increase for those guests >> when running within KVM. >> >> If only a single guest is needed on a host, we have a lot of spare host >> CPU time we can throw at the problem. Modern CPUs implement a feature >> called "MWAIT" which allows guests to wake up sleeping remote CPUs without >> an IPI - thus without an exit - at the expense of never going out of guest >> context. >> >> The decision whether this is something sensible to use should be up to the >> VM admin, so to user space. We can however allow MWAIT execution on systems >> that support it properly hardware wise. >> >> This patch adds a CAP to user space and a KVM cpuid leaf to indicate >> availability of native MWAIT execution. With that enabled, the worst a >> guest can do is waste as many cycles as a "jmp ." would do, so it's not >> a privilege problem. > Did you mean "hlt" rather than "jmp" ? No, hlt wouldn't waste cycles, "jmp ." does. The point I'm trying to make here is that by removing the MWAIT trap we don't give the guest more CPU time than we would've granted it before. > >> We consciously do *not* expose the feature in our CPUID bitmap, as most >> people will want to benefit from sleeping vCPUs to allow for over commit. >> >> Reported-by: "Gabriel L. Somlo" > That's maybe a bit inacurate, I didn't actually report anything *this* > patch is trying to address (that was rather commit 87c00572ba05aa8c9d). > > Maybe > > Acked-by: Gabriel Somlo > > would be a more accurate statement instead? Works for me :). I'm sure whoever applies this can swizzle the tag? Alex