Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753110AbdDKMpt (ORCPT ); Tue, 11 Apr 2017 08:45:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:42586 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbdDKMpq (ORCPT ); Tue, 11 Apr 2017 08:45:46 -0400 Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() To: Daniel Kiper References: <20170331101438.28582-1-jgross@suse.com> <20170403124257.GA3439@router-fw-old.local.net-space.pl> Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, ptesarik@suse.com, daniel.kiper@oracle.com, eric.devolder@oracle.com, konrad.wilk@oracle.com, andrew.cooper3@citrix.com From: Juergen Gross Message-ID: <1df1de5c-8f89-3d65-b0cb-15a2a78992f8@suse.com> Date: Tue, 11 Apr 2017 14:45:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170403124257.GA3439@router-fw-old.local.net-space.pl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 22 On 03/04/17 14:42, Daniel Kiper wrote: > On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote: >> For kdump to work correctly it needs the physical address of >> vmcoreinfo_note. When running as dom0 this means the virtual address >> has to be translated to the related machine address. >> >> paddr_vmcoreinfo_note() is meant to do the translation via >> __pa_symbol() only, but being attributed "weak" it can be replaced >> easily in Xen case. >> >> Signed-off-by: Juergen Gross > > Have you tested this patch with latest crash tool? Do dom0 and Xen > hypervisor analysis work without any issue (at least basic commands > like dmesg, bt, ps, etc.)? If yes for both you can add: > > Reviewed-by: Daniel Kiper So can I add your R-b: now? Juergen