Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbdDKNso (ORCPT ); Tue, 11 Apr 2017 09:48:44 -0400 Received: from mail-sn1nam02on0044.outbound.protection.outlook.com ([104.47.36.44]:28400 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751350AbdDKNsl (ORCPT ); Tue, 11 Apr 2017 09:48:41 -0400 From: Javier Gonzalez To: Bart Van Assche CC: =?utf-8?B?TWF0aWFzIEJqw7hybGluZw==?= , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4] lightnvm: pblk Thread-Topic: [PATCH v4] lightnvm: pblk Thread-Index: AQHSsilq+Mxdx2H/W0KU+VWcbhvgcKG/D8sAgAEgg4A= Date: Tue, 11 Apr 2017 13:48:37 +0000 Message-ID: References: <1491849399-12798-1-git-send-email-javier@cnexlabs.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: sandisk.com; dkim=none (message not signed) header.d=none;sandisk.com; dmarc=none action=none header.from=cnexlabs.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.106.164.211] x-microsoft-exchange-diagnostics: 1;DM5PR06MB2634;7:YzUl8EPJ8vmQ6cLzzXE4wiE2EcnfGaffVksRFfIeTl7cjbS1gRUW+2EmLpuY6WHKvmufB75ts7aDK1maXgeOupFXInz67QK4PJ68aSJ6GXhXxs95n/Ytm76KxINJ2TCD7NMEcUQIatsB6FG8/x8yWsdSqppRn4p3N38lGuyqxN3r3f9cQg3honR0fQiOOYjwU0cXUJL6RegTm9pCNHC98yxDJEHOFClvh613Ov0E/zuMaDaCzhLtnvVvti9xeSMNXZYUnUFTff9CjftmRcyPNxWdEhxMLG5oU5DrzF4AorVT3ZO0paE3/neFLJ9Xw90h4bYmk5/0UkBY4mmAkql6TQ== x-ms-office365-filtering-correlation-id: dac8974a-0617-47f3-894f-08d480e174a2 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075);SRVR:DM5PR06MB2634; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42932892334569); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(102415395)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:DM5PR06MB2634;BCL:0;PCL:0;RULEID:;SRVR:DM5PR06MB2634; x-forefront-prvs: 0274272F87 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39400400002)(39410400002)(39830400002)(377454003)(24454002)(53546009)(33656002)(25786009)(102836003)(6116002)(3846002)(7736002)(229853002)(66066001)(6916009)(2950100002)(82746002)(99936001)(36756003)(2906002)(54356999)(50986999)(76176999)(3280700002)(3660700001)(305945005)(4326008)(189998001)(86362001)(110136004)(6246003)(38730400002)(6436002)(122556002)(6506006)(5660300001)(6486002)(77096006)(99286003)(54906002)(53936002)(83716003)(6512007)(8676002)(8936002)(81166006)(8656002)(2900100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR06MB2634;H:DM5PR06MB2636.namprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/signed; boundary="Apple-Mail=_E7F9834B-4443-4F30-A23B-A61D429F9EA7"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: cnexlabs.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2017 13:48:37.6156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e40dfc2e-c6c1-463a-a598-38602b2c3cff X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR06MB2634 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2770 Lines: 78 --Apple-Mail=_E7F9834B-4443-4F30-A23B-A61D429F9EA7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Bart, > On 10 Apr 2017, at 22.35, Bart Van Assche = wrote: >=20 > On 04/10/2017 11:36 AM, Javier Gonz=C3=A1lez wrote: >> Changes since v3: >> * Apply Bart's feedback [1] >=20 > Thanks for having addressed these comments. But please also make sure > that the pblk driver builds cleanly with W=3D1 C=3D2. When running = "make > M=3Ddrivers/lightnvm W=3D1 C=3D2" several warnings are reported that = should be > reviewed. At least the endianness warnings should be addressed. An = example: >=20 > CHECK drivers/lightnvm/pblk-gc.c > drivers/lightnvm/pblk-gc.c:254:18: warning: incorrect type in = assignment > (different base types) > drivers/lightnvm/pblk-gc.c:254:18: expected unsigned long long > [usertype] *lba_list > drivers/lightnvm/pblk-gc.c:254:18: got restricted __le64 [usertype] = * >=20 > Please also review the warnings reported by smatch (make > M=3Ddrivers/lightnvm C=3D2 CHECK=3D"smatch -p=3Dkernel"). A few = examples that > most likely indicate bugs: >=20 > CHECK drivers/lightnvm/pblk-init.c > drivers/lightnvm/pblk-init.c:915: pblk_init() error: passing non > negative 1 to ERR_PTR > drivers/lightnvm/pblk-rb.c:782: pblk_rb_tear_down_check() error: we > previously assumed 'rb->entries' could be null (see line 778) CHECK > drivers/lightnvm/pblk-read.c > drivers/lightnvm/pblk-read.c:486: pblk_submit_read_gc() error: 'bio' > dereferencing possible ERR_PTR() I'll submit a v5 later today where these are addressed. Thanks. >=20 > Thanks, >=20 > Bart. Javier --Apple-Mail=_E7F9834B-4443-4F30-A23B-A61D429F9EA7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJY7N60AAoJECF+MVChUZ50DugQAL35wrXal/Ta4HxHmymL/UC4 5wmUngVawlLXshTzlYhKJ0Wy0nnUg7lHbD2vh5XFn2zoRfDr2k5zcVad/PHHzMZX MnYeOlYMVE/pan7CHsAXt0vXstMRUwQGNbnxmdjvHKLVZEaioGtHimylduXnYgQ9 S8AtxpD6bVBqCwmpS15FruOpPcP1kxcB5Ofvz3buRHB4DGjT0+WOh1GQH23Thiri U41/olK1MDGiFE2iy6VC5rRg5CKCUtUWnlIbd4hO/5AmvPiOHW+RguryP2cgztSw 3wY/JaOah6u9lzLx9fESyvNWXzk3iVDd4NgJv995Z3fYXGLgaxmuZUwTUDSM3TaF OOegAwICgeJzGtVjNsXkL5x0sMgZi+BRLGdNrZQ1djfPM2FuKlIIYUXMOmmtpCj1 fA4ziexYj+3e9cBGBQuaFnuIIim5jLUk0XHk9uJe1mlid9ysF16b9hHI27BzdTuo 9rV7vGRUx7/52dT+kWpNTMtZMvRAW3oNzhRtmhNto2K85NbqVHQZzItLq4u5Fghe /c0dS+X3LSjxOe6e0kBiLAPxSRgEO5f/rL+kGhdqqw9z3OEfZ06FUKLQW2roKXZv 2WIlgcjNSv5kit9lukR2hvmFB558cck4IeRufaPDoZARf908Vp5jaJPO92efxiag Bm55FGcXs8bHrnxW1OG4 =cO2k -----END PGP SIGNATURE----- --Apple-Mail=_E7F9834B-4443-4F30-A23B-A61D429F9EA7--