Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754056AbdDKO1v (ORCPT ); Tue, 11 Apr 2017 10:27:51 -0400 Received: from mail.kernel.org ([198.145.29.136]:41814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753597AbdDKO1r (ORCPT ); Tue, 11 Apr 2017 10:27:47 -0400 MIME-Version: 1.0 In-Reply-To: <20170411092238.19624-1-tklauser@distanz.ch> References: <20170411092238.19624-1-tklauser@distanz.ch> From: Alan Tull Date: Tue, 11 Apr 2017 09:27:03 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] fpga: allow to compile-test Altera FPGA bridge drivers To: Tobias Klauser Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel , matthew.gerlach@linux.intel.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 51 On Tue, Apr 11, 2017 at 4:22 AM, Tobias Klauser wrote: Hi Tobias, Thanks for your fixes that you have been sending. I disagree with this particular one (see below), but I appreciate your efforts. > Add COMPILE_TEST to the Kconfig entries for the Altera SoCFPGA FPGA > Bridge and the Altera FPGA Freeze Bridge drivers to allow test-compiling > them on other architectures. > > Signed-off-by: Tobias Klauser > --- > drivers/fpga/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 161ba9dccede..38ab05d261bf 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -69,14 +69,14 @@ config FPGA_BRIDGE > > config SOCFPGA_FPGA_BRIDGE > tristate "Altera SoCFPGA FPGA Bridges" > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > + depends on (ARCH_SOCFPGA || COMPILE_TEST) && FPGA_BRIDGE It doesn't make sense to compile test these on other arch's. The bridges enabled by this only appear on Cyclone 5 SoCFPGA parts. > help > Say Y to enable drivers for FPGA bridges for Altera SOCFPGA > devices. > > config ALTERA_FREEZE_BRIDGE > tristate "Altera FPGA Freeze Bridge" > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > + depends on (ARCH_SOCFPGA || COMPILE_TEST) && FPGA_BRIDGE These bridges can be used on Altera PCIe FPGA's. So this shouldn't have been dependent on ARCH_SOCFPGA in the first place. Alan > help > Say Y to enable drivers for Altera FPGA Freeze bridges. A > freeze bridge is a bridge that exists in the FPGA fabric to > -- > 2.12.2 > >