Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbdDKOry (ORCPT ); Tue, 11 Apr 2017 10:47:54 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60126 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914AbdDKOrv (ORCPT ); Tue, 11 Apr 2017 10:47:51 -0400 Date: Tue, 11 Apr 2017 10:47:49 -0400 (EDT) Message-Id: <20170411.104749.1916353709565387637.davem@davemloft.net> To: Jie.Deng1@synopsys.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 11 Apr 2017 07:06:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 491 Lines: 13 From: Jie Deng Date: Tue, 11 Apr 2017 16:14:04 +0800 > It is necessary to provide ethtool support for displaying and > modifying parameters of dwc-xlgmac. > > Signed-off-by: Jie Deng I don't see why you cannot allow the statistics to be obtained when the device is not running. Similarly for other ethtool calls that just fetch information stored in the software state of the driver. I think your ->begin() method is way too restrictive.