Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbdDKOt2 (ORCPT ); Tue, 11 Apr 2017 10:49:28 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60158 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdDKOt0 (ORCPT ); Tue, 11 Apr 2017 10:49:26 -0400 Date: Tue, 11 Apr 2017 10:49:24 -0400 (EDT) Message-Id: <20170411.104924.1724009300333538121.davem@davemloft.net> To: sean.wang@mediatek.com Cc: john@phrozen.org, nbd@openwrt.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, keyhaede@gmail.com Subject: Re: [PATCH net-next] net: ethernet: mediatek: enhance TX path with recycling more SKBs in one poll From: David Miller In-Reply-To: <1491899667-19596-1-git-send-email-sean.wang@mediatek.com> References: <1491899667-19596-1-git-send-email-sean.wang@mediatek.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 11 Apr 2017 07:08:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 16 From: Date: Tue, 11 Apr 2017 16:34:27 +0800 > From: Sean Wang > > The patch adds the enhancement for recycling more TX completed SKBs in > one NAPI polling handler if NAPI budgets are still available and hardware > raises status bit shown for certain SKBs are aready done. > > Signed-off-by: Sean Wang You should always, unconditionally, process all TX reclaim events every NAPI poll, regardless of how much budget is left. TX reclaim work is not counted against the NAPI budget, only RX work should be.