Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752319AbdDKP7B (ORCPT ); Tue, 11 Apr 2017 11:59:01 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:60075 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751372AbdDKP67 (ORCPT ); Tue, 11 Apr 2017 11:58:59 -0400 Subject: Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable References: <20170324161854.GA6958@fury> <87efxi8d82.fsf@concordia.ellerman.id.au> <20170328022354.GA590@localhost.localdomain> To: Darren Hart , Michael Ellerman Cc: Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, bamvor.zhangjian@huawei.com, stable@vger.kernel.org, Shuah Khan From: Shuah Khan Message-ID: <33903dfc-9ee3-d6cb-0868-c13c84941e08@osg.samsung.com> Date: Tue, 11 Apr 2017 09:58:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170328022354.GA590@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1591 Lines: 46 On 03/27/2017 08:23 PM, Darren Hart wrote: > On Tue, Mar 28, 2017 at 11:19:25AM +1100, Michael Ellerman wrote: >> Darren Hart writes: >> >>> The use of $$OUTPUT in the target shell commands resulted in an empty >>> string followed by an absolute path for which mkdir failed: >>> >>> $ make -C tools/testing/selftests/futex >>> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex' >>> Makefile:36: warning: overriding recipe for target 'clean' >>> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >>> for DIR in functional; do \ >>> BUILD_TARGET=$OUTPUT/$DIR; \ >>> mkdir $BUILD_TARGET -p; \ >>> make OUTPUT=$BUILD_TARGET -C $DIR all;\ >>> done >>> mkdir: cannot create directory ‘/functional’: Permission denied >>> >>> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT >>> variable. The above make command now completes successfully. >>> >>> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT") >>> Signed-off-by: Darren Hart (VMware) >>> Cc: linux-kselftest@vger.kernel.org >>> Cc: bamvor.zhangjian@huawei.com >>> Cc: Shuah Khan >>> Cc: # 4.10.x- >> >> The OUTPUT support only went into v4.11-rc1, so I don't see why you need >> a stable tag? > > Git spelunking failure on my part, you are correct. Please disregard the stable > tag. > >> >> Change looks good though. >> > > Thank you for the review. > Thanks for fixing this. Applied to linux-kselftest next after removing the stable tag. -- Shuah