Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752904AbdDKQGg (ORCPT ); Tue, 11 Apr 2017 12:06:36 -0400 Received: from anholt.net ([50.246.234.109]:46396 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdDKQGf (ORCPT ); Tue, 11 Apr 2017 12:06:35 -0400 From: Eric Anholt To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111 In-Reply-To: <20170411093737.GV17774@n2100.armlinux.org.uk> References: <20170411011801.15788-1-eric@anholt.net> <20170411093737.GV17774@n2100.armlinux.org.uk> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 11 Apr 2017 09:06:31 -0700 Message-ID: <8737df0vzs.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1609 Lines: 40 --=-=-= Content-Type: text/plain Russell King - ARM Linux writes: > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: >> v5: Move register definitions inside the driver directory, fix build >> in COMPILE_TEST and !AMBA mode. > > Why is it necessary to move the register definitions there, when > they're already available in linux/amba/clcd.h and are required > for the FB driver? > > It is absurd to have driver specific register definitions. Because after v2, v3, and v4, I still didn't have an ack on the patch to move the register definitions from linux/amba/clcd.h to linux/amba/clcd-reg.h. If you'd like to go back and ack that, I'd reuse them. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljs/wcACgkQtdYpNtH8 nuhACg/9EDo3QA8eQXScqSZqJ+izMc8InC/J6ghIR1zLnNqs12dcvNbnZcWEijps WHTZ3h/yGWa/qyPg0ROm606VTe43rn5hfpZ1f3dkWiCo5mb0xh92/4mPNnkAWlxh O0dw1NOPTB1iNGqwRNSINGVcv5ByxkZFMrAZZqHdgqQ74avjkUfyOHdVsPODGMz3 bwYkjhP+YulL7sOSMBd+I4yOAvPAAnNClpWzgz3K8VOxaddJjf8Q8U9GIxYd5CZR syDg0/dSp5n3Tx8r0RIgiaO2jfgLXoJPhMygpeI4JZ4a+tEYSBjA3Pjs53dhn/XS OAwjE3Rfl6SAZLdqgT+/eQjE/TsPngpzdBvlcKusfQNOB1UDAf8+6uQ2u8agT/5Z KleGgwmumjr5nFlf5Z6WAcP7/N+hbaJ1C6+Yc0tncV3vqj7Y+SXnco3R0y2eHCoA 3P2VQbZRpHonY3WdCI6IMM7nxSJQgNmgwDrVDdNSa7Fi3hQh5Z6pX+RN1HCDvM9p T8S19kKxykZmvA/HCH80WSN7zjPcs0kUaicE0KbRTfWGVf1milO0X+Rf1H0UOV2b HWeyYFlWwmsaOZ2RyayIbXDnoansQW67pi9IKuIsHwgowDZXjil9cqsOBJ3QvTJu Pg4YVZDHTI/ocz8oCzv5fpIMJaD9KISLgIOdbiCpNjcLn4CuRnw= =/6bx -----END PGP SIGNATURE----- --=-=-=--