Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbdDKQXd (ORCPT ); Tue, 11 Apr 2017 12:23:33 -0400 Received: from resqmta-ch2-04v.sys.comcast.net ([69.252.207.36]:34888 "EHLO resqmta-ch2-04v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbdDKQXa (ORCPT ); Tue, 11 Apr 2017 12:23:30 -0400 Date: Tue, 11 Apr 2017 11:23:28 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Kees Cook cc: Michal Hocko , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux-MM , LKML Subject: Re: [PATCH] mm: Add additional consistency check In-Reply-To: Message-ID: References: <20170404113022.GC15490@dhcp22.suse.cz> <20170404151600.GN15132@dhcp22.suse.cz> <20170404194220.GT15132@dhcp22.suse.cz> <20170404201334.GV15132@dhcp22.suse.cz> <20170411134618.GN6729@dhcp22.suse.cz> <20170411141956.GP6729@dhcp22.suse.cz> Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfJL4JC2dka3LBN+V5wQetQ1sq3U7lN+8WvGXTtUkoTBaE4ZSgF7bT0SjjXQUdDQM4AQLAYfow4oqdBHifBT3CC2ngZHzzZmNwOsdwkh3O2owVjTyLmEA wIKsGAbuuBevc7eEv2s6EeyTEZ/05REzCBLH7H0O/UJu0hxHtk6Palstht8O9MUiXZDQpbb5v2tj46y2RQoHYyQfT3GQa1tHR/3Ck/arKdfUW0VqQQKiC1CP 4p4IGMWdUorVUCLUjkL4+MUS+d8QnwJ4OvIAOiqwtTiptDRuDIBjjbJYQ8T2QanGwYhwaO2OKQHUs0HtKRgSOTsdfMswExPDM42eoT+7WsKHe2qIDT8NOTsb dfjEDgrjMO3o6pVIkhmGAiTPB28GJONoQzYXlxZKpqfCkZGMeJM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 324 Lines: 8 On Tue, 11 Apr 2017, Kees Cook wrote: > It seems that enabling the debug checks comes with a non-trivial > performance impact. I'd like to see consistency checks by default so > we can handle intentional heap corruption attacks better. This check > isn't expensive... Its in a very hot code and frequently used code path.