Message-ID: <1491938603.17839.25.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: special audit for revert commit line
From: Joe Perches <joe@perches.com>
To: Wei Wang <wvw@google.com>, apw@canonical.com,
        Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Date: Tue, 11 Apr 2017 12:23:23 -0700
In-Reply-To: <20170411191532.74381-1-wvw@google.com>
References: <20170411191532.74381-1-wvw@google.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1075
Lines: 27

On Tue, 2017-04-11 at 12:15 -0700, Wei Wang wrote:
> From: Wei Wang <wvw@google.com>
> 
> Currently checkpatch.pl does not recognize git's default
> commit revert message and will complain about the hash format.
> Add special audit for revert commit message line to fix it.
> 
> Signed-off-by: Wei Wang <wvw@google.com>

Acked-by: Joe Perches <joe@perches.com>

> ---
>  scripts/checkpatch.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index baa3c7be04ad..9570db236ba3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2539,6 +2539,7 @@ sub process {
>  # Check for git id commit length and improperly formed commit descriptions
>  		if ($in_commit_log && !$commit_log_possible_stack_dump &&
>  		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
> +		    $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
>  		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
>  		     ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
>  		      $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&