Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbdDKUnd (ORCPT ); Tue, 11 Apr 2017 16:43:33 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753334AbdDKUnc (ORCPT ); Tue, 11 Apr 2017 16:43:32 -0400 Subject: Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block To: Oleksij Rempel , dedekind1@gmail.com, adrian.hunter@intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20170411095055.26328-1-o.rempel@pengutronix.de> <20170411095055.26328-4-o.rempel@pengutronix.de> Cc: Steffen Trumtrar From: Richard Weinberger Message-ID: <5d7d0f21-d87f-0835-c2f6-b6c9e07f73a8@nod.at> Date: Tue, 11 Apr 2017 22:43:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170411095055.26328-4-o.rempel@pengutronix.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 30 Oleksij, Am 11.04.2017 um 11:50 schrieb Oleksij Rempel: > From: Steffen Trumtrar > > This is need to provide uuid based integrity functionlity for: > imy_policy (fsuuid option) and evmctl (--uuid option). > > Signed-off-by: Steffen Trumtrar > Signed-off-by: Oleksij Rempel > --- > fs/ubifs/super.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index bff1e8d6f7bd..a584b2f2b11d 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -2077,6 +2077,7 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) > err = -ENOMEM; > goto out_umount; > } > + memcpy(&sb->s_uuid, &c->uuid, sizeof(c->uuid)); Makes sense. Artem, do you remember why UBIFS didn't set s_uuid in first place? Thanks, //richard