Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753558AbdDKVA2 (ORCPT ); Tue, 11 Apr 2017 17:00:28 -0400 Received: from anholt.net ([50.246.234.109]:48616 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbdDKVA0 (ORCPT ); Tue, 11 Apr 2017 17:00:26 -0400 From: Eric Anholt To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111 In-Reply-To: <20170411181021.GW17774@n2100.armlinux.org.uk> References: <20170411011801.15788-1-eric@anholt.net> <20170411093737.GV17774@n2100.armlinux.org.uk> <8737df0vzs.fsf@eliezer.anholt.net> <20170411181021.GW17774@n2100.armlinux.org.uk> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 11 Apr 2017 14:00:21 -0700 Message-ID: <87shleek2i.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1920 Lines: 48 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Russell King - ARM Linux writes: > On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote: >> Russell King - ARM Linux writes: >>=20 >> > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: >> >> v5: Move register definitions inside the driver directory, fix build >> >> in COMPILE_TEST and !AMBA mode. >> > >> > Why is it necessary to move the register definitions there, when >> > they're already available in linux/amba/clcd.h and are required >> > for the FB driver? >> > >> > It is absurd to have driver specific register definitions. >>=20 >> Because after v2, v3, and v4, I still didn't have an ack on the patch to >> move the register definitions from linux/amba/clcd.h to >> linux/amba/clcd-reg.h. If you'd like to go back and ack that, I'd reuse >> them. > > I don't remember seeing such a patch, sorry. https://patchwork.kernel.org/patch/9654991/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljtQ+UACgkQtdYpNtH8 nujfEQ//VPXaxM0lPmYBBLiMAGQtLwiGYTFFIqaiBUpJ0NFV0sDMFH24GTSgJdQU W9e4eONXcwohDo0Mlc75CmKceu5LZlNKErgTxoEg1M4UO1dWZwUR6Zu7duX5AL9q prjY9J/pYdHob4Xr7vGI96EhLyP4wjeH92ygJ4QiwncgZxHLeQMY+eYz8CK64+ya bGhjB4NFAJJc6tqIB6ZW3u212BpkItNyKKrNywTh+s/6aArg6otSN26SiCYaSlwX KezCcT+r0LpLole6UvCAwhrhLXUhTY9gy1JqOcv52sOMxxl3grRipZVdNI9bcXRc wCPKwj7+5dKge59rsSfjo+lVZgn3blD1y3Mi+MXwCGT+OHEXCAFFBVTppcbURqqj NlyW6lRN6xY+dZ4tGN5gDlwIJYIMp1xQrLn9JavvuH4Ul7ZOMmxrYEVQ0kQBp7SD 371o53OrXxD0KaHr5AF+vCfkHmyGA6UwlNEoD9bGEAUSTlv/O2PdnPTrbnq9gTh9 rUQqnZXHYiDYnxg/lpsAahMvWAodprJpETAUeT7vQ0mw2sExXoURQEJI9KQ2KxAp pkf9NAV05XV3pbZN72HwZ0P4jSaRjLSTOXBz76GvAKqyh4s8E4rYL+X7p5vgISIH iTnC8UpH697Od8TcyPxgva6TdEsm6KjleOVJUepymbCv4sp/dII= =U9fJ -----END PGP SIGNATURE----- --=-=-=--