Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbdDKWNy (ORCPT ); Tue, 11 Apr 2017 18:13:54 -0400 Received: from anholt.net ([50.246.234.109]:49074 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbdDKWNw (ORCPT ); Tue, 11 Apr 2017 18:13:52 -0400 From: Eric Anholt To: Linus Walleij Cc: "open list\:DRM PANEL DRIVERS" , Tom Cooksey , Russell King , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111 In-Reply-To: References: <20170411011801.15788-1-eric@anholt.net> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 11 Apr 2017 15:13:49 -0700 Message-ID: <87lgr6ego2.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3115 Lines: 69 --=-=-= Content-Type: text/plain Linus Walleij writes: > On Tue, Apr 11, 2017 at 3:18 AM, Eric Anholt wrote: > >> From: Tom Cooksey > > Well that can be debated at this point. I think it should have > your Author: tag and just Tom in the Signed-off-by, then mention > the history in the commit message. > >> This is a modesetting driver for the pl111 CLCD display controller >> found on various ARM platforms such as the Versatile Express. The >> driver has only been tested on the bcm911360_entphn platform so far, >> with PRIME-based buffer sharing between vc4 and clcd. >> >> It reuses the existing devicetree binding, while not using quite as >> many of its properties as the fbdev driver does (those are left for >> future work). >> >> v2: Nearly complete rewrite by anholt, cutting 2/3 of the code thanks >> to DRM core's excellent new helpers. >> v3: Don't match pl110 any more, don't attach if we don't have a DRM >> panel, use DRM_GEM_CMA_FOPS, update MAINTAINERS, use the simple >> display helper, use drm_gem_cma_dumb_create (same as our wrapper). >> v4: Change the driver's .name to not clash with fbdev in sysfs, drop >> platform alias, drop redundant "drm" in DRM driver name, hook up >> .prepare_fb to the CMA helper so that DMA fences should work. >> v5: Move register definitions inside the driver directory, fix build >> in COMPILE_TEST and !AMBA mode. >> >> Signed-off-by: Tom Cooksey >> Signed-off-by: Eric Anholt > > Reviewed-by: Linus Walleij > > This is as good starting point as any. We need to get moving with > this. Some minor things below that can just as well be fixed later. Oh, one last thing I think we need to figure out: I'm using TIM2_CLKSEL, which seems to be necessary on this platform. My understanding is that this means that the pixel clock is divided from clcdclk instead of apb_pclk. Do you agree? The fbdev driver is using clk_get(&fb->dev->dev, NULL) and not TIM2_CLKSEL, which I'm surprised by because I would have thought that would give us the first clock from the DT node (also clcdclk). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljtVR0ACgkQtdYpNtH8 nujECRAAhEidWJVuRKQeHCPhTkQ4xAzl3wol61GfYT1WtpHSuwOBk2rYpQQSYsN/ MRDDJ4bFC8/3327LmaUkRfbvXxgWux1ttRNeN1wYBC2j6EPtyqCwI3hVp3oNUq40 SHqGbXTVi1pLjZkFGkgSUzFLlmZXfheK97aRPoElLRjoTc8XP2JJCHtmpmkIAMIp RdTmHTMsUjGrle0ZB5f+Kb4FwNSfPO9KgRPrBbDUvLoxpf4IRPpIg8AbafU6l35I NcntPfgNnEPXMZ5/3teXD3txl+ohqFo5gtkrt3+b8vc1gAt2lRtPoAtjuPfXRMf7 2LdRG2SnrfLl4m3fE6WhXNSTrrd7gss39isybwx+g5HPiS1f1L27OhpbPipQCrkV 1IZZpk26blg/ZHxIPj5Mdnwij3sKm+wm0OjX61xdcY4BBzfdg8uWrwhR0hRqBz1Y hhbRR56LOCGkqoBQurczPFJxmLqhgRHGczcQY71IJB7+dSBGIeS86wE51v+Klgmh w3NvikuqgKdq1/6YhTDFfjrcBguPgZUDgHnwrjSj8y+9Ye1dDUL3gI9T7diLtmBT cdOJkUAwZioQwPgSMz/zqHY7MsG7x9H/9SUL48m242EcrAFoo2ADCgmDpR7vmga7 mNvQUlBpBOSuX7ZXPaj/skhuBnCJXsw8JV/sFKyyuWL2u8cC0mE= =vmd7 -----END PGP SIGNATURE----- --=-=-=--