Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753589AbdDKXqD (ORCPT ); Tue, 11 Apr 2017 19:46:03 -0400 Received: from scorn.kernelslacker.org ([45.56.101.199]:39730 "EHLO scorn.kernelslacker.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbdDKXp7 (ORCPT ); Tue, 11 Apr 2017 19:45:59 -0400 Date: Tue, 11 Apr 2017 19:45:58 -0400 From: Dave Jones To: Al Viro Cc: Linux Kernel Subject: Re: iov_iter_pipe warning. Message-ID: <20170411234558.zyzxznzaas3ge7qe@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Al Viro , Linux Kernel References: <20170410194206.loesu5licstif7or@codemonkey.org.uk> <20170410195711.GD29622@ZenIV.linux.org.uk> <20170410234830.tmqdhpjtfdveor3c@codemonkey.org.uk> <20170411002215.GE29622@ZenIV.linux.org.uk> <20170411030532.vcam25fz6224ny2h@codemonkey.org.uk> <20170411032839.GF29622@ZenIV.linux.org.uk> <20170411205336.uyz5vfw52twhh6ob@codemonkey.org.uk> <20170411211216.GH29622@ZenIV.linux.org.uk> <20170411222502.ldgahltwvrrxdbbw@codemonkey.org.uk> <20170411232842.GI29622@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170411232842.GI29622@ZenIV.linux.org.uk> User-Agent: NeoMutt/20170306 (1.8.0) X-Spam-Note: SpamAssassin invocation failed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 25 On Wed, Apr 12, 2017 at 12:28:42AM +0100, Al Viro wrote: > On Tue, Apr 11, 2017 at 06:25:02PM -0400, Dave Jones wrote: > > > ffffffff812b3130 T generic_splice_sendpage > > > > This one spat out all by itself. > > No need to print ->f_op for that one - can be only socket_file_ops. Now, > the address family of that socket would be interesting... > > How about adding to that printk (under if (WARN_ON()) something like > file = sd->u.file; > if (file->f_op->splice_write == generic_splice_sendpage) { > struct socket *sock = file->private_data; > printk(KERN_ERR "socket [%d, %p]\n", sock->type, sock->ops); > } > printk(KERN_ERR "in->f_op = %p\n", in->f_op); Ugh, this explodes with a million errors when I try to compile it. It misses socket definition, and include causes another cascade of errors about linkage.h and nonsense. Send me a diff, I'll check in later. Dave