Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbdDKXwC (ORCPT ); Tue, 11 Apr 2017 19:52:02 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:36706 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbdDKXwA (ORCPT ); Tue, 11 Apr 2017 19:52:00 -0400 Date: Wed, 12 Apr 2017 00:51:58 +0100 From: Al Viro To: Dave Jones , Linux Kernel Subject: Re: iov_iter_pipe warning. Message-ID: <20170411235158.GK29622@ZenIV.linux.org.uk> References: <20170410195711.GD29622@ZenIV.linux.org.uk> <20170410234830.tmqdhpjtfdveor3c@codemonkey.org.uk> <20170411002215.GE29622@ZenIV.linux.org.uk> <20170411030532.vcam25fz6224ny2h@codemonkey.org.uk> <20170411032839.GF29622@ZenIV.linux.org.uk> <20170411205336.uyz5vfw52twhh6ob@codemonkey.org.uk> <20170411211216.GH29622@ZenIV.linux.org.uk> <20170411222502.ldgahltwvrrxdbbw@codemonkey.org.uk> <20170411232842.GI29622@ZenIV.linux.org.uk> <20170411234558.zyzxznzaas3ge7qe@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170411234558.zyzxznzaas3ge7qe@codemonkey.org.uk> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 14 On Tue, Apr 11, 2017 at 07:45:58PM -0400, Dave Jones wrote: > > if (file->f_op->splice_write == generic_splice_sendpage) { > > struct socket *sock = file->private_data; > > printk(KERN_ERR "socket [%d, %p]\n", sock->type, sock->ops); > > } > > printk(KERN_ERR "in->f_op = %p\n", in->f_op); > > Ugh, this explodes with a million errors when I try to compile it. > It misses socket definition, and include causes another > cascade of errors about linkage.h and nonsense. Ignore the socket part - you've already triggered it with NFS file as destination, so this is not particularly interesting. I would still like to see in->f_op and even more - the checks in default_file_splice_read().