Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbdDLFKW (ORCPT ); Wed, 12 Apr 2017 01:10:22 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:60467 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbdDLFKU (ORCPT ); Wed, 12 Apr 2017 01:10:20 -0400 Subject: Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support To: David Miller , References: <20170411.104749.1916353709565387637.davem@davemloft.net> CC: , From: Jie Deng Message-ID: <2a437683-a422-4db0-8583-7b002e74e71d@synopsys.com> Date: Wed, 12 Apr 2017 13:08:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170411.104749.1916353709565387637.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 15 On 2017/4/11 22:47, David Miller wrote: > From: Jie Deng > Date: Tue, 11 Apr 2017 16:14:04 +0800 > >> It is necessary to provide ethtool support for displaying and >> modifying parameters of dwc-xlgmac. >> >> Signed-off-by: Jie Deng > I don't see why you cannot allow the statistics to be obtained when > the device is not running. Similarly for other ethtool calls that > just fetch information stored in the software state of the driver. > > I think your ->begin() method is way too restrictive. Yeah, begin() seems unreasonable here. I will remove it.